Page MenuHomeFreeBSD
Differential D42098

uiomove: Add some assertions
ClosedPublic
Actions

Authored by markj on Oct 5 2023, 9:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 6:26 AM
Unknown Object (File)
Thu, Oct 17, 2:22 AM
Unknown Object (File)
Thu, Oct 17, 2:21 AM
Unknown Object (File)
Thu, Oct 17, 2:21 AM
Unknown Object (File)
Thu, Oct 17, 1:49 AM
Unknown Object (File)
Sep 23 2024, 8:16 PM
Unknown Object (File)
Sep 19 2024, 9:49 AM
Unknown Object (File)
Sep 19 2024, 1:25 AM
View All 51 Files
Subscribers
emaste
imp
jhibbits
riscv

Details

Reviewers
kib
glebius
andrew
manu
Commits
rG2d49b111a312: uiomove: Add some assertions
rGeb8923452e1e: uiomove: Add some assertions
rG8fd0ec53deaa: uiomove: Add some assertions
Summary

Make sure that we don't try to copy with a negative resid.

Make sure that we don't walk off the end of the iovec array.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Oct 5 2023, 9:36 PM
Herald added a reviewer: andrew. · View Herald TranscriptOct 5 2023, 9:36 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: riscv, jhibbits, emaste, imp. · View Herald Transcript
markj requested review of this revision.Oct 5 2023, 9:36 PM
Harbormaster completed remote builds in B53861: Diff 128332.Oct 5 2023, 9:36 PM
markj added a child revision: D42099: ktrace: Handle uio_resid underflow via MSG_TRUNC.Oct 5 2023, 9:36 PM
imp added a comment.Oct 5 2023, 9:50 PM

Any way to trigger these from userland? I'd think high level tests prevent that...

kib accepted this revision.Oct 5 2023, 9:59 PM
This revision is now accepted and ready to land.Oct 5 2023, 9:59 PM
markj added a comment.Oct 5 2023, 10:01 PM
In D42098#960314, @imp wrote:

Any way to trigger these from userland? I'd think high level tests prevent that...

D42099 fixes one bug which can trigger these assertions, yes.

Closed by commit rG8fd0ec53deaa: uiomove: Add some assertions (authored by markj). · Explain WhyOct 17 2023, 1:38 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG8fd0ec53deaa: uiomove: Add some assertions.
markj added a commit: rGeb8923452e1e: uiomove: Add some assertions.Oct 24 2023, 1:38 PM
markj added a commit: rG2d49b111a312: uiomove: Add some assertions.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
6 lines
arm/
arm/
6 lines
arm64/
arm64/
6 lines
i386/
i386/
6 lines
kern/
5 lines
powerpc/
powerpc/
5 lines
riscv/
riscv/
6 lines

Diff 128909

View Options

sys/amd64/amd64/uio_machdep.c

Loading...
View Options

sys/arm/arm/uio_machdep.c

Loading...
View Options

sys/arm64/arm64/uio_machdep.c

Loading...
View Options

sys/i386/i386/uio_machdep.c

Loading...
View Options

sys/kern/subr_uio.c

Loading...
View Options

sys/powerpc/powerpc/uio_machdep.c

Loading...
View Options

sys/riscv/riscv/uio_machdep.c

Loading...