Page MenuHomeFreeBSD
Differential D41998

tcp: Eliminate one usage of TUNABLE_INT_FETCH
ClosedPublic
Actions

Authored by zlei on Sep 27 2023, 10:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 9 2025, 7:31 PM
Unknown Object (File)
Feb 5 2025, 12:48 AM
Unknown Object (File)
Feb 4 2025, 6:31 AM
Unknown Object (File)
Feb 3 2025, 11:40 PM
Unknown Object (File)
Feb 3 2025, 6:10 AM
Unknown Object (File)
Jan 26 2025, 7:21 PM
Unknown Object (File)
Jan 25 2025, 2:03 PM
Unknown Object (File)
Nov 30 2024, 6:35 PM
View All 40 Files
Subscribers
cc
imp
melifaro

Details

Reviewers
glebius
tuexen
cc
rscheff
Group Reviewers
transport
Commits
rG0a31dbecd43d: tcp: Simplify the initialization of loader tunable 'net.inet.tcp.tcbhashsize'
rG379f41a117eb: tcp: Simplify the initialization of loader tunable 'net.inet.tcp.tcbhashsize'
rG3a97686fc11a: tcp: Simplify the initialization of loader tunable 'net.inet.tcp.tcbhashsize'
rG38ecc80b2a4e: tcp: Simplify the initialization of loader tunable 'net.inet.tcp.tcbhashsize'
Summary

The code will be simpler.

No functional change intended.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Sep 27 2023, 10:26 AM
Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptSep 27 2023, 10:26 AM
Herald added subscribers: melifaro, imp. · View Herald Transcript
zlei requested review of this revision.Sep 27 2023, 10:26 AM
zlei added inline comments.
sys/netinet/tcp_subr.c
318

@glebius Does it need CTLFLAG_NEEDGIANT ?

zlei added a reviewer: tuexen.Oct 2 2023, 12:01 AM
cc accepted this revision as: cc.Oct 2 2023, 9:25 PM
cc added a subscriber: cc.

My understanding too here is that CTLFLAG_NOFETCH is not used, and so is CTLFLAG_NEEDGIANT not needed.

rscheff accepted this revision.Oct 3 2023, 7:14 AM
This revision is now accepted and ready to land.Oct 3 2023, 7:14 AM
Closed by commit rG38ecc80b2a4e: tcp: Simplify the initialization of loader tunable 'net.inet.tcp.tcbhashsize' (authored by zlei). · Explain WhyOct 8 2023, 10:06 AM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG38ecc80b2a4e: tcp: Simplify the initialization of loader tunable 'net.inet.tcp.tcbhashsize'.
zlei added a commit: rG3a97686fc11a: tcp: Simplify the initialization of loader tunable 'net.inet.tcp.tcbhashsize'.Oct 16 2023, 3:18 PM
zlei added a commit: rG379f41a117eb: tcp: Simplify the initialization of loader tunable 'net.inet.tcp.tcbhashsize'.Oct 16 2023, 3:44 PM
zlei added a commit: rG0a31dbecd43d: tcp: Simplify the initialization of loader tunable 'net.inet.tcp.tcbhashsize'.Oct 16 2023, 3:51 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
30 lines

Diff 128419

View Options

sys/netinet/tcp_subr.c

  • This file was added.
# Created by: Jonathan Anderson <jonathan@FreeBSD.org>
# $FreeBSD$
PORTNAME= git-cola
PORTVERSION= 2.2.1
DISTVERSIONPREFIX= v
CATEGORIES= devel
MAINTAINER= ports@FreeBSD.org
COMMENT= Sleek and powerful Git GUI
pgollucciUnsubmitted
Done
Inline Actions

mainter should be ports@ or yourself

pgollucci: mainter should be ports@ or yourself
brooksUnsubmitted
Done
Inline Actions

MAINTAINER should be submitter. We shouldn't commit pre-orphaned ports.

brooks: MAINTAINER should be submitter. We shouldn't commit pre-orphaned ports.
LICENSE= GPLv2
USE_GITHUB= yes
USES= desktop-file-utils gettext gmake python
INSTALLS_ICONS= YES
brdUnsubmitted
Done
Inline Actions

GH_ACCOUNT & GH_PROJECT can both be removed since they default to the value of ${PORTNAME}: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-master_sites-github-description

brd: GH_ACCOUNT & GH_PROJECT can both be removed since they default to the value of ${PORTNAME}…
MAKE_FLAGS= "prefix=${PREFIX}"
.include <bsd.port.mk>