Page MenuHomeFreeBSD
Differential D41423

iscsictl: Return non-zero status on write failure.
ClosedPublic
Actions

Authored by yanhaowang on Aug 11 2023, 6:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 18, 7:46 AM
Unknown Object (File)
Wed, May 13, 4:51 PM
Unknown Object (File)
Wed, May 13, 4:50 PM
Unknown Object (File)
Wed, May 13, 4:50 PM
Unknown Object (File)
Wed, May 13, 4:50 PM
Unknown Object (File)
Wed, May 13, 4:40 PM
Unknown Object (File)
Mon, May 4, 2:32 AM
Unknown Object (File)
Sun, May 3, 3:53 PM
View All Files
Subscribers
imp

Details

Reviewers
lwhsu
des
Commits
rG00f003da7d07: iscsictl(8): Complete libxo transition

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yanhaowang created this revision.Aug 11 2023, 6:38 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 11 2023, 6:38 AM
yanhaowang requested review of this revision.Aug 11 2023, 6:38 AM
Harbormaster completed remote builds in B53047: Diff 125860.Aug 11 2023, 6:38 AM
yanhaowang added reviewers: lwhsu, des.Aug 11 2023, 6:38 AM
des requested changes to this revision.Aug 17 2023, 3:27 PM
des added inline comments.
usr.bin/iscsictl/iscsictl.c
712

These fprintf() calls should be replaced with xo_error().

This revision now requires changes to proceed.Aug 17 2023, 3:27 PM
yanhaowang updated this revision to Diff 126256.Aug 20 2023, 7:04 AM
  • Using xo_error instead of 'fprintf'.
  • Decide use number style here.
Harbormaster completed remote builds in B53186: Diff 126256.Aug 20 2023, 7:05 AM
des accepted this revision.Aug 27 2023, 12:00 AM
des added inline comments.
usr.bin/iscsictl/iscsictl.c
1058

Everything from here on down could be written as exit(!!failed);, but it's also fine as-is.

This revision is now accepted and ready to land.Aug 27 2023, 12:00 AM
Closed by commit rG00f003da7d07: iscsictl(8): Complete libxo transition (authored by yanhaowang, committed by lwhsu). · Explain WhyOct 12 2024, 6:30 PM
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: rG00f003da7d07: iscsictl(8): Complete libxo transition.

Revision Contents
Changeset List

PathSize
usr.bin/
iscsictl/
31 lines

Diff 144742

View Options

usr.bin/iscsictl/iscsictl.c

Loading...