vm_phys_enq_range: no alignment assert for npages==0
ClosedPublic
Actions

Authored by dougm on Aug 4 2023, 2:07 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 3, 10:55 PM

	Unknown Object (File)
	Jan 27 2025, 2:50 AM

	Unknown Object (File)
	Jan 27 2025, 2:29 AM

	Unknown Object (File)
	Jan 27 2025, 2:29 AM

	Unknown Object (File)
	Jan 21 2025, 2:03 AM

	Unknown Object (File)
	Jan 12 2025, 8:16 AM

	Unknown Object (File)
	Jan 12 2025, 5:40 AM

	Unknown Object (File)
	Jan 12 2025, 5:32 AM

View All 41 Files

Subscribers

imp

Details

Reviewers

alc
kib
• karels

Commits

rGccdb28275db7: vm_phys_enq_range: no alignment assert for npages==0

Summary

Do not assume that when vm_phys_enq_range is passed npages==0 that the vm_page argument is valid in any way, much less that it has a page-aligned address. Just don't look at it. Assert nothing about it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.Aug 4 2023, 2:07 AM

dougm created this revision.

This looks right to me, and works on my system. Perhaps a comment in the block before the routine would be appropriate, saying that npages may be zero, in which case nothing should be done.

Add to the preface comment that npages may be zero.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 4 2023, 6:44 PM

Closed by commit rGccdb28275db7: vm_phys_enq_range: no alignment assert for npages==0 (authored by dougm). · Explain Why

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rGccdb28275db7: vm_phys_enq_range: no alignment assert for npages==0.

Herald added a subscriber: imp. · View Herald TranscriptAug 4 2023, 6:44 PM