Page MenuHomeFreeBSD
Differential D41249

vm_map: Add a macro to fetch a map entry's split boundary index
ClosedPublic
Actions

Authored by markj on Jul 31 2023, 4:53 PM.
Tags
None
Referenced Files
F107326607: D41249.diff
Sun, Jan 12, 1:14 PM
Unknown Object (File)
Sat, Dec 14, 12:49 PM
Unknown Object (File)
Dec 6 2024, 10:59 PM
Unknown Object (File)
Nov 27 2024, 3:39 PM
Unknown Object (File)
Nov 27 2024, 3:39 PM
Unknown Object (File)
Nov 27 2024, 3:39 PM
Unknown Object (File)
Nov 27 2024, 3:19 PM
Unknown Object (File)
Nov 18 2024, 10:42 PM
View All 40 Files
Subscribers
imp

Details

Reviewers
alc
kib
dougm
Commits
rG5abba9619cbb: vm_map: Add a macro to fetch a map entry's split boundary index
rGd0e4e53ebd64: vm_map: Add a macro to fetch a map entry's split boundary index
Summary

The resulting code is a bit more concise. No functional change
intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jul 31 2023, 4:53 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 31 2023, 4:53 PM
markj requested review of this revision.Jul 31 2023, 4:53 PM
Harbormaster completed remote builds in B52906: Diff 125379.Jul 31 2023, 4:53 PM
kib accepted this revision.Jul 31 2023, 7:34 PM
kib added inline comments.
sys/vm/vm_map.h
158

?

This revision is now accepted and ready to land.Jul 31 2023, 7:34 PM
dougm added a comment.Aug 1 2023, 3:47 AM

I'm fine with the vm parts. I can't find the change you're offering to kern_proc.c.

alc accepted this revision.Aug 1 2023, 5:38 AM
markj marked an inline comment as done.Aug 1 2023, 2:04 PM
In D41249#939639, @dougm wrote:

I'm fine with the vm parts. I can't find the change you're offering to kern_proc.c.

Ah, sorry, that's from a local diff that I've been carrying around. I'll drop that bit before committing.

sys/vm/vm_map.h
158

Since the macro is not widely used, I prefer to keep it unabbreviated.

Closed by commit rGd0e4e53ebd64: vm_map: Add a macro to fetch a map entry's split boundary index (authored by markj). · Explain WhyAug 1 2023, 2:13 PM
This revision was automatically updated to reflect the committed changes.
markj marked an inline comment as done.
markj added a commit: rGd0e4e53ebd64: vm_map: Add a macro to fetch a map entry's split boundary index.
markj added a commit: rG5abba9619cbb: vm_map: Add a macro to fetch a map entry's split boundary index.Aug 9 2023, 8:57 PM

Revision Contents
Changeset List

PathSize
sys/
vm/
3 lines
4 lines
13 lines

Diff 125417

View Options

sys/vm/vm_fault.c

Loading...
View Options

sys/vm/vm_map.h

Loading...
View Options

sys/vm/vm_map.c

Loading...