linker
ClosedPublic
Actions

Authored by jrtc27 on Jul 25 2023, 9:32 PM.

Details

Reviewers

brooks
jhb
emaste
imp

Commits

rG65f28f63a73d: tools/build: Create toolchain symlinks for non-absolute compiler/linker

Summary

If any of the toolchain variables are not absolute then we need to
create a symlink in WORLDTMP/legacy/bin in order to make them available
during a BUILD_WITH_STRICT_TMPPATH build.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 requested review of this revision.Jul 25 2023, 9:32 PM

jrtc27 created this revision.

Harbormaster completed remote builds in B52841: Diff 125158.Jul 25 2023, 9:32 PM

brooks accepted this revision.Jul 25 2023, 9:53 PM

brooks added inline comments.

tools/build/Makefile
379	Is PATH previously constrained here such that we need to add /usr/local/bin?
380	I think we also define `/nonexistant` to not exist of openssh, but I guess this is more portable?

This revision is now accepted and ready to land.Jul 25 2023, 9:53 PM

jrtc27 added inline comments.Jul 25 2023, 9:55 PM

tools/build/Makefile
379	Yes; Makefile sanitises it for FreeBSD (previously all OSes, which is what broke macOS/arm64 due to Homebrew using /opt/homebrew/bin)
380	This entire block is just a copy of the _host_tools_to_symlink code but with _LINK_HOST_TOOL (and _toolchain_tools_to_symlink)