Page MenuHomeFreeBSD

tools/build: Create toolchain symlinks for non-absolute compiler/linker
ClosedPublic

Authored by jrtc27 on Jul 25 2023, 9:32 PM.
Tags
None
Referenced Files
F132261311: D41188.id125158.diff
Wed, Oct 15, 7:09 AM
F132261308: D41188.id.diff
Wed, Oct 15, 7:09 AM
F132261301: D41188.id125235.diff
Wed, Oct 15, 7:09 AM
Unknown Object (File)
Tue, Oct 14, 9:03 PM
Unknown Object (File)
Mon, Sep 29, 8:23 AM
Unknown Object (File)
Sep 10 2025, 10:30 AM
Unknown Object (File)
Aug 29 2025, 7:44 PM
Unknown Object (File)
Aug 18 2025, 3:52 AM
Subscribers
None

Details

Summary

If any of the toolchain variables are not absolute then we need to
create a symlink in WORLDTMP/legacy/bin in order to make them available
during a BUILD_WITH_STRICT_TMPPATH build.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrtc27 created this revision.
brooks added inline comments.
tools/build/Makefile
379

Is PATH previously constrained here such that we need to add /usr/local/bin?

380

I think we also define /nonexistant to not exist of openssh, but I guess this is more portable?

This revision is now accepted and ready to land.Jul 25 2023, 9:53 PM
tools/build/Makefile
379

Yes; Makefile sanitises it for FreeBSD (previously all OSes, which is what broke macOS/arm64 due to Homebrew using /opt/homebrew/bin)

380

This entire block is just a copy of the _host_tools_to_symlink code but with _LINK_HOST_TOOL (and _toolchain_tools_to_symlink)