Page MenuHomeFreeBSD

atkbc: Better test for old chromebooks
ClosedPublic

Authored by imp on Jun 28 2023, 6:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 5, 9:17 AM
Unknown Object (File)
Fri, Jul 5, 8:57 AM
Unknown Object (File)
Wed, Jun 26, 10:34 PM
Unknown Object (File)
Wed, Jun 26, 10:34 PM
Unknown Object (File)
Sat, Jun 22, 4:38 AM
Unknown Object (File)
Sat, Jun 22, 4:28 AM
Unknown Object (File)
Sat, Jun 22, 4:26 AM
Unknown Object (File)
Thu, Jun 20, 2:19 PM
Subscribers

Details

Summary

Implement a test recommended by MrChromebox <mrchromebox@gmail.com>: If
the bios.version starts with Google_, or the maker is either Google or
GOOGLE, assume that it's a chromebook with the affected bios. While this
isn't strictly true, the number of updated systems without the bug is
very small and this will exclude all the modern coreboot uses. There's
no simple way to test the hardware.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52319
Build 49210: arc lint + arc unit

Event Timeline

imp requested review of this revision.Jun 28 2023, 6:33 PM
imp created this revision.
This revision is now accepted and ready to land.Jun 28 2023, 6:44 PM

D40787 applied the quirks for {"coreboot", "Acer", "Peppy"}, but this change does not...?

Also, please properly quote the match strings in the description / commit message.

jrtc27 added inline comments.
sys/dev/atkbdc/atkbdc.c
139

This is a bit of a behaviour change; now it's prefix matching everything, whereas you really only want this for Google_

update comments
and go ahead and implement two different marcos, one
to match the first part, and one for equality. Likely
not going to make a difference in practice, but now the code matches
the comments.

This revision now requires review to proceed.Jun 28 2023, 8:05 PM
sys/dev/atkbdc/atkbdc.c
139

Yea, I debated what to do. Prefix matching won't change what we match today.
But it's likely better to separate the two concepts.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 29 2023, 2:35 PM
This revision was automatically updated to reflect the committed changes.