- User Since
- Feb 18 2015, 3:56 AM (231 w, 1 h)
Nov 19 2015
Nov 6 2015
Change sysctl_add_oid()'s "arg2" (which is what the macro's "val" maps to) to intmax_t, to ensure it can hold any value.
Hopefully clean up some merge cruft in man9/Makefile, and correct the types of the "val" arguments in the manpage.
Be careful; there aren't CTASSERTs for the type of val and if you add them it may take a while to flush out all misuses there
Huh. I synced and did `svn diff', and man9/Makefile only shows my additions. (Or is that the problem - once I created the review, I shouldn't sync anymore until it's submitted?)
Typoed and forgot to include sysctl.9
Nov 5 2015
Aug 12 2015
Aug 5 2015
Looks good to me.
Jun 7 2015
I'm hardly an expert on the queue macros - or C++ - but this change seems reasonable to me. I assume `make universe' works?
Mar 5 2015
One of my colleagues dug into the first LOR - the one that happens when adding em1 to lagg0, which happens both with and without the patch. It looks like this is a known issue:
Mar 3 2015
4079 addresses @rstone's comments. However, the LOR remains:
Updating D1986: Teach lagg(4) to change MTU
Addressing review comments from rstone: