Page MenuHomeFreeBSD

rpokala-panasas.com (Ravi Pokala)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 18 2015, 3:56 AM (231 w, 1 h)

Recent Activity

Nov 19 2015

rpokala-panasas.com added inline comments to D4126: popen requires check for fdopen failure.
Nov 19 2015, 11:20 PM

Nov 6 2015

rpokala-panasas.com updated D4091: Round out SYSCTL macros for the full set of signed and unsigned integers..
Nov 6 2015, 10:59 PM
rpokala-panasas.com added a comment to D4091: Round out SYSCTL macros for the full set of signed and unsigned integers..
Nov 6 2015, 10:34 PM
rpokala-panasas.com updated the diff for D4091: Round out SYSCTL macros for the full set of signed and unsigned integers..

Change sysctl_add_oid()'s "arg2" (which is what the macro's "val" maps to) to intmax_t, to ensure it can hold any value.

Nov 6 2015, 10:32 PM
rpokala-panasas.com updated the diff for D4091: Round out SYSCTL macros for the full set of signed and unsigned integers..

Hopefully clean up some merge cruft in man9/Makefile, and correct the types of the "val" arguments in the manpage.

Nov 6 2015, 6:36 PM
rpokala-panasas.com added a comment to D4091: Round out SYSCTL macros for the full set of signed and unsigned integers..

Be careful; there aren't CTASSERTs for the type of val and if you add them it may take a while to flush out all misuses there

Nov 6 2015, 5:53 PM
rpokala-panasas.com added a comment to D4091: Round out SYSCTL macros for the full set of signed and unsigned integers..

Huh. I synced and did `svn diff', and man9/Makefile only shows my additions. (Or is that the problem - once I created the review, I shouldn't sync anymore until it's submitted?)

Nov 6 2015, 5:41 PM
rpokala-panasas.com added inline comments to D4095: Fix infinite loops in yplib.c.
Nov 6 2015, 3:08 PM
rpokala-panasas.com updated the diff for D4091: Round out SYSCTL macros for the full set of signed and unsigned integers..

Typoed and forgot to include sysctl.9

Nov 6 2015, 4:55 AM
rpokala-panasas.com retitled D4091: Round out SYSCTL macros for the full set of signed and unsigned integers. from to Round out SYSCTL macros for the full set of signed and unsigned integers..
Nov 6 2015, 4:53 AM

Nov 5 2015

rpokala-panasas.com retitled D4086: Add RIDs to dump_rman() from to Add RIDs to dump_rman().
Nov 5 2015, 5:12 PM

Aug 12 2015

rpokala-panasas.com accepted D3300: LAG LACP timeout tunable through IOCTL.

Thanks LN.

Aug 12 2015, 5:01 PM

Aug 5 2015

rpokala-panasas.com accepted D3300: LAG LACP timeout tunable through IOCTL.

Looks good to me.

Aug 5 2015, 8:17 AM

Jun 7 2015

rpokala-panasas.com added a comment to D2745: Make "sys/queue.h" usable with C++.

I'm hardly an expert on the queue macros - or C++ - but this change seems reasonable to me. I assume `make universe' works?

Jun 7 2015, 12:31 PM

Mar 5 2015

rpokala-panasas.com added a comment to D1986: Teach lagg(4) to change MTU.

One of my colleagues dug into the first LOR - the one that happens when adding em1 to lagg0, which happens both with and without the patch. It looks like this is a known issue:

Mar 5 2015, 10:19 PM

Mar 3 2015

rpokala-panasas.com added a comment to D1986: Teach lagg(4) to change MTU.

4079 addresses @rstone's comments. However, the LOR remains:

Mar 3 2015, 1:40 AM
rpokala-panasas.com updated the diff for D1986: Teach lagg(4) to change MTU.

Updating D1986: Teach lagg(4) to change MTU

Addressing review comments from rstone:

Mar 3 2015, 1:28 AM

Mar 1 2015

rpokala-panasas.com added a comment to D1986: Teach lagg(4) to change MTU.
In D1986#4, @ae wrote:

Just a thought. Imagine two interfaces, one has maximum MTU 2200, another 1500. lagg0 has MTU 1400.
Two threads invokes changing MTU in the same time. One wants to change it to 2000, another - to 1500.
It is possible, that when both threads will finish its job, one interface will have MTU 1400, but another - 1500.
I mean, that such changes should be done exclusively without possibility of races in the ioctl code.

Mar 1 2015, 9:49 PM

Feb 28 2015

rpokala-panasas.com retitled D1986: Teach lagg(4) to change MTU from to Teach lagg(4) to change MTU.
Feb 28 2015, 3:32 AM
rpokala-panasas.com updated D1985: PR 197379: Add an option to run `syslogd' in the foreground.
Feb 28 2015, 3:22 AM
rpokala-panasas.com updated D1985: PR 197379: Add an option to run `syslogd' in the foreground.
Feb 28 2015, 3:21 AM
rpokala-panasas.com retitled D1985: PR 197379: Add an option to run `syslogd' in the foreground from to PR 197379: Add an option to run `syslogd' in the foreground.
Feb 28 2015, 3:20 AM
rpokala-panasas.com edited P52 PR 197379: Add an option to run `syslogd' in the foreground.
Feb 28 2015, 3:15 AM

Feb 26 2015

rpokala-panasas.com added inline comments to D1968: Make the LSFR in sched_ule a function and use it always..
Feb 26 2015, 12:22 AM
rpokala-panasas.com added a comment to D1968: Make the LSFR in sched_ule a function and use it always..
Feb 26 2015, 12:20 AM