Fix infinite loops in yplib.c
ClosedPublic
Actions

Authored by pushkarbk_gmail.com on Nov 6 2015, 12:20 PM.

Details

Reviewers

rpokala-panasas.com
bapt
araujo

Commits

rS291073: If a NIS server has long entries on its database that is bigger than

Summary

Configuring NIS server to use longer entries, creates an infinite retry loop for a NIS request.
A ypmatch call will return the following error until the command is killed:

yp_match: clnt_call: RPC: Can't decode result ***

Test Plan

Before Fix * ***

ypmatch sss_group1910 group

yp_match: clnt_call: RPC: Can't decode result
yp_match: clnt_call: RPC: Can't decode result
yp_match: clnt_call: RPC: Can't decode result
yp_match: clnt_call: RPC: Can't decode result
yp_match: clnt_call: RPC: Can't decode result
yp_match: clnt_call: RPC: Can't decode result
.
.
.
. * Infinite Loop *
.
.
.
yp_match: clnt_call: RPC: Can't decode result
yp_match: clnt_call: RPC: Can't decode result
yp_match: clnt_call: RPC: Can't decode result

After CTRL+C

yp_match: clnt^Catch: clnt_call: RPC: Can't decode result

After Fix * ******

ypmatch sss_group1910 group

yp_match: clnt_call: RPC: Can't decode result
yp_match: clnt_call: RPC: Can't decode result
.
.
.
. * After 20 retries *
.
.
ypmatch: can't match key sss_group1910 in map group.byname. reason: RPC failure

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pushkarbk_gmail.com updated this revision to Diff 9988.Nov 6 2015, 12:20 PM

pushkarbk_gmail.com retitled this revision from to Fix infinite loops in yplib.c.

pushkarbk_gmail.com updated this object.

pushkarbk_gmail.com edited the test plan for this revision. (Show Details)

pushkarbk_gmail.com added reviewers: rpokala-panasas.com, hiren.

rpokala-panasas.com added inline comments.Nov 6 2015, 3:08 PM

lib/libc/yp/yplib.c
983 ↗	(On Diff #9988)	Pushkar and I talked about this internally, but noting it here for the record - the reason the first arg to cln_perror() was changed was to match the first arg of the clnt_call() which failed.