Differential D40613

Warn about nonfunctional WITH/WITHOUT options
ClosedPublic
Actions

Authored by cperciva on Jun 20 2023, 4:43 AM.

Tags

None

Referenced Files

	F144434322: D40613.id123565.diff
	Sun, Feb 8, 10:26 AM

	F144420894: D40613.id123463.diff
	Sun, Feb 8, 8:41 AM

	F144408476: D40613.id123471.diff
	Sun, Feb 8, 7:12 AM

	Unknown Object (File)
	Sun, Feb 1, 9:31 AM

	Unknown Object (File)
	Sat, Jan 31, 12:23 PM

	Unknown Object (File)
	Sat, Jan 31, 8:14 AM

	Unknown Object (File)
	Sat, Jan 31, 4:54 AM

	Unknown Object (File)
	Fri, Jan 30, 1:48 AM

View All 91 Files

Subscribers

Details

Reviewers

emaste
imp
sjg

Commits

rG824b64a2f1a0: Warn about nonfunctional WITHOUT options

Summary

Print a warning if we try to build WITH_ an option which is marked as
"broken" (and forced off) or WITHOUT_ an option which is marked as
"required" (and forced on).

Suggested by: emaste, imp

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cperciva created this revision.Jun 20 2023, 4:43 AM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptJun 20 2023, 4:43 AM

cperciva requested review of this revision.Jun 20 2023, 4:43 AM

Harbormaster completed remote builds in B52149: Diff 123463.Jun 20 2023, 4:43 AM

cperciva added reviewers: emaste, imp, sjg.Jun 20 2023, 4:44 AM

imp added inline comments.Jun 20 2023, 4:55 AM

share/mk/bsd.mkopt.mk
96	This should not be committed. It will be too noisy for how we use BROKEN. People often have WITH_XXX in their make.conf that would throw errors on some architectures.

Remove warning for WITH_ options marked as broken.

Harbormaster completed remote builds in B52155: Diff 123471.Jun 20 2023, 6:40 AM

cperciva marked an inline comment as done.Jun 20 2023, 6:40 AM

cperciva added inline comments.

share/mk/bsd.mkopt.mk
96	Ok, I've removed that part.

imp accepted this revision.Jun 20 2023, 8:41 AM

imp added inline comments.

share/mk/bsd.mkopt.mk
96	Thanks!

This revision is now accepted and ready to land.Jun 20 2023, 8:41 AM

emaste accepted this revision.Jun 20 2023, 5:00 PM

Closed by commit rG824b64a2f1a0: Warn about nonfunctional WITHOUT options (authored by cperciva). · Explain WhyJun 20 2023, 8:59 PM

This revision was automatically updated to reflect the committed changes.

cperciva marked an inline comment as done.

cperciva added a commit: rG824b64a2f1a0: Warn about nonfunctional WITHOUT options.

Revision Contents
Changeset List

Path

Size

share/

mk/

3 lines

Diff 123565

share/mk/bsd.mkopt.mk

Loading...