Warn about nonfunctional WITH/WITHOUT options
ClosedPublic
Actions

Authored by cperciva on Jun 20 2023, 4:43 AM.

Details

Reviewers

emaste
imp
sjg

Commits

rG824b64a2f1a0: Warn about nonfunctional WITHOUT options

Summary

Print a warning if we try to build WITH_ an option which is marked as
"broken" (and forced off) or WITHOUT_ an option which is marked as
"required" (and forced on).

Suggested by: emaste, imp

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52155
Build 49046: arc lint + arc unit

Event Timeline

cperciva created this revision.Jun 20 2023, 4:43 AM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptJun 20 2023, 4:43 AM

cperciva requested review of this revision.Jun 20 2023, 4:43 AM

Harbormaster completed remote builds in B52149: Diff 123463.Jun 20 2023, 4:43 AM

cperciva added reviewers: emaste, imp, sjg.Jun 20 2023, 4:44 AM

imp added inline comments.Jun 20 2023, 4:55 AM

share/mk/bsd.mkopt.mk
96	This should not be committed. It will be too noisy for how we use BROKEN. People often have WITH_XXX in their make.conf that would throw errors on some architectures.