armv8crypto: Avoid overriding -march when compiling some source files
ClosedPublic
Actions

Authored by markj on Jun 14 2023, 2:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 3, 10:47 AM

	Unknown Object (File)
	Wed, Sep 2, 9:05 PM

	Unknown Object (File)
	Wed, Aug 26, 11:34 AM

	Unknown Object (File)
	Wed, Aug 26, 11:32 AM

	Unknown Object (File)
	Sun, Aug 23, 9:22 PM

	Unknown Object (File)
	Aug 18 2026, 5:44 AM

	Unknown Object (File)
	Aug 14 2026, 2:27 PM

	Unknown Object (File)
	Aug 10 2026, 8:29 PM

Subscribers

Details

Reviewers

andrew
imp

Group Reviewers

arm64

Commits

rG1ee66195db08: armv8crypto: Avoid overriding -march when compiling some source files

Summary

At least one downstream (CheriBSD) overrides -march here. Instead of
hard-coding the target, simply append the crypto extension to whatever's
already there.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jun 14 2023, 2:46 PM

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptJun 14 2023, 2:46 PM

markj requested review of this revision.Jun 14 2023, 2:46 PM

Harbormaster completed remote builds in B52047: Diff 123203.Jun 14 2023, 2:46 PM

andrew accepted this revision.Jun 14 2023, 3:05 PM

This revision is now accepted and ready to land.Jun 14 2023, 3:05 PM

imp accepted this revision.Jun 14 2023, 7:08 PM

Closed by commit rG1ee66195db08: armv8crypto: Avoid overriding -march when compiling some source files (authored by markj). · Explain WhyJun 15 2023, 4:40 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG1ee66195db08: armv8crypto: Avoid overriding -march when compiling some source files.

Revision Contents
Changeset List

Path

Size

sys/

conf/

files.arm64

6 lines

Diff 123287

View Options

armv8crypto: Avoid overriding -march when compiling some source filesClosedPublicActions