Page MenuHomeFreeBSD
Differential D40352

setusercontext(): Set priority from '~/.login_conf' as well
ClosedPublic
Actions

Authored by olce on May 31 2023, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 17, 4:39 PM
Unknown Object (File)
Fri, May 17, 4:39 PM
Unknown Object (File)
Fri, May 17, 4:39 PM
Unknown Object (File)
Fri, May 17, 4:39 PM
Unknown Object (File)
Fri, May 17, 4:39 PM
Unknown Object (File)
Fri, May 17, 4:39 PM
Unknown Object (File)
Wed, May 15, 11:52 PM
Unknown Object (File)
Wed, May 15, 11:38 PM
View All 53 Files
Subscribers
andrew_tao173.riddles.org.uk
imp

Details

Reviewers
kib
mjg
yuripv
kevans
des
olce
Commits
rGd2d66fedc418: setusercontext(): Set priority from '~/.login_conf' as well
rG8b359002747a: setusercontext(): Set priority from '~/.login_conf' as well
rGf2a0277d3e51: setusercontext(): Set priority from '~/.login_conf' as well
Summary

Setting the process priority is done only when the current process' effective
UID corresponds to that for which context is to be set. Consequently, setting
priority is done with appropriate credentials and will fail if the target user
tries to raise it unduly via his '.login_conf'.

PR: 271751

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51806
Build 48697: arc lint + arc unit

Event Timeline

olce created this revision.May 31 2023, 3:18 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 31 2023, 3:18 PM
olce requested review of this revision.May 31 2023, 3:18 PM
Harbormaster completed remote builds in B51806: Diff 122661.May 31 2023, 3:18 PM
olce added a parent revision: D40351: setusercontext(): Apply user login context only on process' euid being set.May 31 2023, 3:19 PM
andrew_tao173.riddles.org.uk added a subscriber: andrew_tao173.riddles.org.uk.May 31 2023, 4:42 PM

Should be conditional on LOGIN_SETPRIORITY, no?

olce updated this revision to Diff 122667.May 31 2023, 4:52 PM

Yes, of course...

It seems I messed up with this patch, with pieces of earlier versions chiming in
(e.g., the superfluous include of <stdbool.h>).

Here is an updated version.

Harbormaster completed remote builds in B51809: Diff 122667.May 31 2023, 4:52 PM
olce updated this revision to Diff 122668.May 31 2023, 4:53 PM

Good patch this time...

Harbormaster completed remote builds in B51810: Diff 122668.May 31 2023, 4:53 PM
olce added reviewers: kib, mjg, yuripv, kevans, des.Jun 6 2023, 8:29 AM
olce updated this revision to Diff 123009.Jun 9 2023, 2:56 PM
olce edited the summary of this revision. (Show Details)

Add PR in commit message.

Harbormaster completed remote builds in B51983: Diff 123009.Jun 9 2023, 2:56 PM
kib accepted this revision.Jun 15 2023, 6:46 AM
This revision is now accepted and ready to land.Jun 15 2023, 6:46 AM
olce updated this revision to Diff 123605.Jun 21 2023, 1:58 PM

Refresh

This revision now requires review to proceed.Jun 21 2023, 1:58 PM
Harbormaster completed remote builds in B52228: Diff 123605.Jun 21 2023, 1:58 PM
olce added a comment.Jun 21 2023, 2:01 PM

@kib Diff is the same as the one you validated. I updated the differential just to update the diff's base.

olce accepted this revision.Jul 16 2023, 4:10 PM

Re-validating, since the diff is the same as validated by @kib.

This revision is now accepted and ready to land.Jul 16 2023, 4:10 PM
olce added a child revision: D43608: login_cap.h: Remove LOGIN_DEFUMASK.Jan 25 2024, 10:54 PM
Closed by commit rGf2a0277d3e51: setusercontext(): Set priority from '~/.login_conf' as well (authored by olce). · Explain WhyJan 29 2024, 10:33 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rGf2a0277d3e51: setusercontext(): Set priority from '~/.login_conf' as well.
olce added a commit: rG8b359002747a: setusercontext(): Set priority from '~/.login_conf' as well.Feb 1 2024, 9:26 PM
olce added a commit: rGd2d66fedc418: setusercontext(): Set priority from '~/.login_conf' as well.Feb 1 2024, 9:32 PM

Revision Contents
Changeset List

PathSize
lib/
libutil/
2 lines

Diff 122661

View Options

lib/libutil/login_class.c

Loading...