Page MenuHomeFreeBSD
Differential D40332

ifnet: consistently call hooks when the interface gets up.
ClosedPublic
Actions

Authored by melifaro on May 30 2023, 12:16 PM.
Tags
None
Referenced Files
F167808553: D40332.id122700.diff
Mon, Aug 24, 5:16 PM
F167716316: D40332.id122605.diff
Sun, Aug 23, 11:17 PM
F167716288: D40332.id122700.diff
Sun, Aug 23, 11:17 PM
F167716259: D40332.diff
Sun, Aug 23, 11:17 PM
Unknown Object (File)
Fri, Aug 21, 7:59 PM
Unknown Object (File)
Tue, Aug 18, 1:09 PM
Unknown Object (File)
Mon, Aug 17, 7:42 AM
Unknown Object (File)
Tue, Aug 4, 4:58 AM
View All Files
Subscribers
ae
glebius
imp

Details

Reviewers
kp
Group Reviewers
network
Commits
rGa77facd27368: ifnet: consistently call hooks when the interface gets up.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

melifaro created this revision.May 30 2023, 12:16 PM
Herald added subscribers: glebius, ae, imp. · View Herald TranscriptMay 30 2023, 12:16 PM
melifaro requested review of this revision.May 30 2023, 12:16 PM
Harbormaster completed remote builds in B51772: Diff 122605.May 30 2023, 12:16 PM
melifaro added reviewers: network, kp.May 30 2023, 12:17 PM
melifaro mentioned this in D40317: carp: add a 'SUPPRESS' state.
kp added inline comments.May 30 2023, 12:23 PM
sys/net/if.c
2233

We lose the call to in6_if_up() here. Is that deliberate, and if so, how sure are we that we're not missing any notifications for link up and subsequent start of DAD?

melifaro added inline comments.May 30 2023, 12:26 PM
sys/net/if.c
2233

in6_if_up() is now called from the eventhandler hook

kp accepted this revision as: kp.May 30 2023, 12:48 PM
kp added inline comments.
sys/net/if.c
2233

Note to self: read the full diff next time. No, really, all of it.

This revision is now accepted and ready to land.May 30 2023, 12:48 PM
Closed by commit rGa77facd27368: ifnet: consistently call hooks when the interface gets up. (authored by melifaro). · Explain WhyJun 1 2023, 11:52 AM
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rGa77facd27368: ifnet: consistently call hooks when the interface gets up..

Revision Contents
Changeset List

PathSize
sys/
net/
36 lines
netinet6/
14 lines
netlink/
route/
4 lines

Diff 122700

View Options

sys/net/if.c

Loading...
View Options

sys/netinet6/in6.c

Loading...
View Options

sys/netlink/route/iface.c

Loading...