Differential D40332

ifnet: consistently call hooks when the interface gets up.
ClosedPublic
Actions

Authored by melifaro on May 30 2023, 12:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 17, 8:35 PM

	Unknown Object (File)
	Fri, Apr 17, 3:48 AM

	Unknown Object (File)
	Mon, Apr 13, 5:16 AM

	Unknown Object (File)
	Sun, Apr 12, 3:30 PM

	Unknown Object (File)
	Sun, Apr 12, 12:09 AM

	Unknown Object (File)
	Thu, Apr 9, 11:29 PM

	Unknown Object (File)
	Fri, Apr 3, 6:26 PM

	Unknown Object (File)
	Thu, Apr 2, 1:02 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGa77facd27368: ifnet: consistently call hooks when the interface gets up.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro created this revision.May 30 2023, 12:16 PM

Herald added subscribers: glebius, ae, imp. · View Herald TranscriptMay 30 2023, 12:16 PM

melifaro requested review of this revision.May 30 2023, 12:16 PM

Harbormaster completed remote builds in B51772: Diff 122605.May 30 2023, 12:16 PM

melifaro added reviewers: network, kp.May 30 2023, 12:17 PM

melifaro mentioned this in D40317: carp: add a 'SUPPRESS' state.

kp added inline comments.May 30 2023, 12:23 PM

sys/net/if.c
2233	We lose the call to in6_if_up() here. Is that deliberate, and if so, how sure are we that we're not missing any notifications for link up and subsequent start of DAD?

melifaro added inline comments.May 30 2023, 12:26 PM

sys/net/if.c
2233	in6_if_up() is now called from the eventhandler hook

kp accepted this revision as: kp.May 30 2023, 12:48 PM

kp added inline comments.

sys/net/if.c
2233	Note to self: read the full diff next time. No, really, all of it.

This revision is now accepted and ready to land.May 30 2023, 12:48 PM

Closed by commit rGa77facd27368: ifnet: consistently call hooks when the interface gets up. (authored by melifaro). · Explain WhyJun 1 2023, 11:52 AM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rGa77facd27368: ifnet: consistently call hooks when the interface gets up..

Revision Contents
Changeset List

Path

Size

sys/

net/

36 lines

netinet6/

14 lines

netlink/

route/

4 lines

Diff 122700

sys/net/if.c

Loading...

sys/netinet6/in6.c

Loading...

sys/netlink/route/iface.c

Loading...