Page MenuHomeFreeBSD
Differential D4026

New flash subcommand for mpsutil(8)
ClosedPublic
Actions

Authored by bapt on Oct 29 2015, 1:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 6:45 PM
Unknown Object (File)
Thu, Oct 31, 9:03 AM
Unknown Object (File)
Sat, Oct 26, 2:34 PM
Unknown Object (File)
Sat, Oct 26, 2:34 PM
Unknown Object (File)
Sat, Oct 26, 2:34 PM
Unknown Object (File)
Sat, Oct 26, 2:34 PM
Unknown Object (File)
Sat, Oct 26, 2:34 PM
Unknown Object (File)
Sat, Oct 26, 2:34 PM
View All Files
Subscribers
allanjude
araujo
emaste
imp
wblock

Details

Reviewers
scottl
wblock
Group Reviewers
manpages
Commits
rS291002: mpsutil/mprutil: add flash subcommand
Summary

Add a new flash subcommand to be able to update firmwares/bios for mps(4)/mpr(4)
controllers both upload and download

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 961
Build 961: arc lint + arc unit

Event Timeline

bapt updated this revision to Diff 9781.Oct 29 2015, 1:46 PM
bapt retitled this revision from to New flash subcommand for mpsutil(8).
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: scottl.
bapt added subscribers: araujo, allanjude.
Herald added a reviewer: manpages. · View Herald TranscriptOct 29 2015, 1:46 PM
Herald added a subscriber: imp. · View Herald Transcript
bapt updated this revision to Diff 9782.Oct 29 2015, 1:49 PM
bapt edited edge metadata.

Update manpage

Herald edited edge metadata. · View Herald TranscriptOct 29 2015, 1:49 PM
emaste added a subscriber: emaste.Oct 29 2015, 2:11 PM
emaste added inline comments.
usr.sbin/mpsutil/Makefile
4

alpha order?

13

Presumably you don't want to leave this.

usr.sbin/mpsutil/mpsutil.8
151

Should these go on separate lines, e.g.

.Ar bios
from the ...
bapt updated this revision to Diff 9788.Oct 29 2015, 2:35 PM
bapt edited edge metadata.

Address @emaste comments

Herald edited edge metadata. · View Herald TranscriptOct 29 2015, 2:35 PM
bapt marked 3 inline comments as done.Oct 29 2015, 2:35 PM
wblock added a subscriber: wblock.Oct 29 2015, 2:36 PM
wblock added inline comments.
usr.sbin/mpsutil/mpsutil.8
108

Please start sentences on new lines.

135

"The" is not really needed here, just "Controller..." works.

146

Probably better with markup for the filename to get rid of the quotes:

is specified then the file will be named
.Pa firmware
or
.Pa bios .
bapt updated this revision to Diff 9789.Oct 29 2015, 2:40 PM
bapt edited edge metadata.

mdoc(7) fixes per @wblock comments

Herald edited edge metadata. · View Herald TranscriptOct 29 2015, 2:40 PM
bapt updated this revision to Diff 9790.Oct 29 2015, 2:41 PM
bapt edited edge metadata.

More mdoc(7) fixes

Herald edited edge metadata. · View Herald TranscriptOct 29 2015, 2:41 PM
bapt marked 3 inline comments as done.Oct 29 2015, 2:41 PM
wblock accepted this revision.Oct 29 2015, 3:28 PM
wblock added a reviewer: wblock.

Man page looks okay, please remember to update .Dd.

This revision is now accepted and ready to land.Oct 29 2015, 3:28 PM
bapt added a comment.Nov 16 2015, 1:46 PM

anyone to test or to review please?

bapt updated this revision to Diff 10275.Nov 17 2015, 7:54 PM
bapt edited edge metadata.

Dn't know why mps_flash.c was not added

This revision now requires review to proceed.Nov 17 2015, 7:54 PM
Closed by commit rS291002: mpsutil/mprutil: add flash subcommand (authored by bapt). · Explain WhyNov 17 2015, 8:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.sbin/
mpsutil/
2 lines
58 lines
3 lines
37 lines

Diff 9788

View Options

usr.sbin/mpsutil/Makefile

Loading...
View Options

usr.sbin/mpsutil/mps_cmd.c

Loading...
View Options

usr.sbin/mpsutil/mps_flash.c

Loading...
View Options

usr.sbin/mpsutil/mpsutil.h

Loading...
View Options

usr.sbin/mpsutil/mpsutil.8

Loading...