eficom: better handling of absent device
ClosedPublic
Actions

Authored by imp on May 22 2023, 10:28 PM.

Details

Reviewers

manu
kevans
tsoome
emaste

Commits

rGf28dff43ad62: stand/efi/eficom: better handling of absent device

Summary

Don't even have a comc_port when the port doesn't exist: always free it
if we probe that it's not there. Also, when it's not present, clear the
flags indicating presence to avoid disturbing other flags.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 51618
Build 48509: arc lint + arc unit

Event Timeline

imp created this revision.May 22 2023, 10:28 PM

Herald added a reviewer: manu. · View Herald TranscriptMay 22 2023, 10:28 PM

Herald added subscribers: dab, bcran. · View Herald Transcript

imp requested review of this revision.May 22 2023, 10:28 PM

Harbormaster completed remote builds in B51618: Diff 122257.May 22 2023, 10:28 PM

imp added a parent revision: D40219: stand/efi/smbios: Move detection of smbios earlier..May 22 2023, 10:28 PM

imp added a child revision: D40221: stand/efi/eficom: Don't allow this for !HYPERV machines.

imp added reviewers: kevans, tsoome, emaste.May 22 2023, 10:31 PM

tsoome accepted this revision.May 23 2023, 7:40 AM

This revision is now accepted and ready to land.May 23 2023, 7:40 AM

gallatin added a subscriber: gallatin.May 23 2023, 1:41 PM

kevans accepted this revision.May 24 2023, 7:48 PM

Closed by commit rGf28dff43ad62: stand/efi/eficom: better handling of absent device (authored by imp). · Explain WhyMay 25 2023, 4:34 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGf28dff43ad62: stand/efi/eficom: better handling of absent device.

Revision Contents
Changeset List

Path

Size

stand/

efi/

libefi/

eficom.c

21 lines

Diff 122257

View Options

stand/efi/eficom: better handling of absent deviceClosedPublicActions