Page MenuHomeFreeBSD
Differential D38425

bridge: Further decompose GRAB_OUR_PACKETS
AbandonedPublic
Actions

Authored by markj on Feb 7 2023, 7:24 PM.
Tags
None
Referenced Files
F135938600: D38425.id116734.diff
Fri, Nov 14, 8:47 AM
Unknown Object (File)
Wed, Nov 12, 4:31 AM
Unknown Object (File)
Tue, Nov 4, 3:42 AM
Unknown Object (File)
Mon, Nov 3, 4:34 AM
Unknown Object (File)
Mon, Nov 3, 3:05 AM
Unknown Object (File)
Sat, Oct 25, 4:49 AM
Unknown Object (File)
Fri, Oct 24, 11:24 AM
Unknown Object (File)
Sat, Oct 18, 8:07 PM
View All 93 Files
Subscribers
ae
glebius
imp
zlei

Details

Reviewers
melifaro
kp
Group Reviewers
network
Summary

Introduce an inline function which consumes a packet known to be
destined for a particular interface. Generally, avoid introducing
macros with side effects.

Add a bridge_learn() helper instead of having the same code duplicated
into the local and forwarding cases.

Simplify some conditionals in bridge_forward().

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49612
Build 46502: arc lint + arc unit

Event Timeline

markj created this revision.Feb 7 2023, 7:24 PM
Herald added subscribers: glebius, ae, imp. · View Herald TranscriptFeb 7 2023, 7:24 PM
markj requested review of this revision.Feb 7 2023, 7:24 PM
Harbormaster completed remote builds in B49612: Diff 116734.Feb 7 2023, 7:24 PM
markj mentioned this in D38410: bridge: Try to make the GRAB_OUR_PACKETS macro a bit more readable.Feb 7 2023, 7:25 PM
markj added a parent revision: D38410: bridge: Try to make the GRAB_OUR_PACKETS macro a bit more readable.
markj added inline comments.Feb 7 2023, 7:32 PM
sys/net/if_bridge.c
2636

One small benefit of this approach is that we don't need to test the bridge interface type. There might be some other simplifications that are possible.

markj added reviewers: kp, network.Feb 7 2023, 8:07 PM
zlei added a subscriber: zlei.Oct 30 2023, 2:05 PM
zlei added inline comments.
sys/net/if_bridge.c
2646

I wonder if we can have a hash map lladdr -> ifp to speed up lookups for bridge which have large quantity members.

markj added a comment.Nov 2 2023, 2:57 PM

I'm not really looking at if_bridge anymore, so I'll drop this patch. If anyone wants to take it and change/improve it, please feel free.

sys/net/if_bridge.c
2646

Yes, that's probably a good idea. Even a flat array would be better than the linked list; now that the data path is protected by an epoch section, it should be pretty easy to implement resizing.

markj abandoned this revision.Jan 14 2025, 4:02 PM

Revision Contents
Changeset List

PathSize
sys/
net/
192 lines

Diff 116734

View Options

sys/net/if_bridge.c

Loading...