Correct some sysctls of the sysctl net.inet.tcp.bb family set.
ClosedPublic
Actions

Authored by cc on Dec 21 2022, 11:26 PM.

Details

Reviewers

tuexen
rscheff

Group Reviewers

transport

Commits

rGb5ca1cd6abad: BBLog: improve sysctl variables
rG57cc27a3325a: BBLog: improve sysctl variables

Summary

Correct the format in sysctl net.inet.tcp.bb.disable_all and sysctl net.inet.tcp.bb.log_auto_all.
Correct the format and the description in net.inet.tcp.bb.log_auto_mode.

Test Plan

Tested the sysctls' output before and after the change.

before:
root@s1:~ # sysctl -d net.inet.tcp.bb.disable_all
net.inet.tcp.bb.disable_all: Disable all BB logging for all connections
root@s1:~ # sysctl net.inet.tcp.bb.disable_all
net.inet.tcp.bb.disable_all: 0

iroot@s1:~ # sysctl -d net.inet.tcp.bb.log_auto_mode
net.inet.tcp.bb.log_auto_mode: Logging mode for auto-selected sessions (default is TCP_LOG_STATE_HEAD_AUTO)
root@s1:~ # sysctl net.inet.tcp.bb.log_auto_mode
net.inet.tcp.bb.log_auto_mode: 1

root@n1:~ # sysctl net.inet.tcp.bb.log_auto_all
net.inet.tcp.bb.log_auto_all: 0
root@n1:~ # sysctl -d net.inet.tcp.bb.log_auto_all
net.inet.tcp.bb.log_auto_all: Auto-select from all sessions (rather than just those with IDs)

after:
root@s1:~ # sysctl -d net.inet.tcp.bb.disable_all
net.inet.tcp.bb.disable_all: Disable all BB logging for all connections
root@s1:~ # sysctl net.inet.tcp.bb.disable_all
net.inet.tcp.bb.disable_all: 0

root@s1:~ # sysctl -d net.inet.tcp.bb.log_auto_mode
net.inet.tcp.bb.log_auto_mode: Logging mode for auto-selected sessions (default is TCP_LOG_STATE_TAIL)
root@s1:~ # sysctl net.inet.tcp.bb.log_auto_mode
net.inet.tcp.bb.log_auto_mode: 1

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cc created this revision.Dec 21 2022, 11:26 PM

Herald added a reviewer: transport. · View Herald TranscriptDec 21 2022, 11:26 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

cc requested review of this revision.Dec 21 2022, 11:26 PM

Harbormaster completed remote builds in B48789: Diff 114392.Dec 21 2022, 11:26 PM

tuexen added inline comments.Dec 22 2022, 8:56 AM

sys/netinet/tcp_log_buf.c
128	Possibly replace `false` by `0` to be consistent with the other declarations, in particular the one for `log_verbose`?

Update the sysctl format for tcp_log_auto_all to be consistent with the sysctl for log_verbose.

Harbormaster completed remote builds in B48795: Diff 114409.Dec 22 2022, 3:14 PM

cc retitled this revision from Correct two sysctls of the sysctl net.inet.tcp.bb family set. to Correct some sysctls of the sysctl net.inet.tcp.bb family set..Dec 22 2022, 3:43 PM

cc edited the summary of this revision. (Show Details)

cc edited the test plan for this revision. (Show Details)

tuexen accepted this revision.Dec 22 2022, 4:46 PM

This revision is now accepted and ready to land.Dec 22 2022, 4:46 PM

Prepare for patch submit.

This revision now requires review to proceed.Dec 22 2022, 8:32 PM

Harbormaster completed remote builds in B48871: Diff 114495.Dec 22 2022, 8:32 PM

I believe Cheng doesn't have the commit bit; I suggest we start the process of onboarding Cheng as another FBSD committer....

This revision is now accepted and ready to land.Dec 23 2022, 10:18 AM

In D37776#860167, @rscheff wrote:

I believe Cheng doesn't have the commit bit; I suggest we start the process of onboarding Cheng as another FBSD committer....

My mistake. I assumed he has a doc commit bit. Now I see, that he did not use an FreeBSD relates e-mail address.
Do you prefer to commit this patch or should I do this?

Closed by commit rG57cc27a3325a: BBLog: improve sysctl variables (authored by cc, committed by tuexen). · Explain WhyDec 24 2022, 9:16 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG57cc27a3325a: BBLog: improve sysctl variables.

tuexen added a commit: rGb5ca1cd6abad: BBLog: improve sysctl variables.Feb 2 2023, 12:05 AM