vmm: Don't lock a vCPU for VM_PPTDEV_MSI[X].
ClosedPublic
Actions

Authored by jhb on Dec 9 2022, 12:55 AM.

Details

Reviewers

markj
corvink

Group Reviewers

bhyve

Commits

rG3bedbb1008a8: vmm: Don't lock a vCPU for VM_PPTDEV_MSI[X].
rG91980db1beec: vmm: Don't lock a vCPU for VM_PPTDEV_MSI[X].

Summary

These are manipulating state in a ppt(4) device none of which is
vCPU-specific. Mark the vcpu fields in the relevant ioctl structures
as unused, but don't remove them for now.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48659
Build 45545: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 9 2022, 12:55 AM

Herald added a reviewer: bhyve. · View Herald TranscriptDec 9 2022, 12:55 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Dec 9 2022, 12:55 AM

Harbormaster completed remote builds in B48659: Diff 113959.Dec 9 2022, 12:55 AM

jhb added a child revision: D37651: bhyve: Pass a vCPU ID of 0 to vm_setup_pptdev_msi*..Dec 9 2022, 1:02 AM

corvink accepted this revision.Dec 9 2022, 7:11 AM

This revision is now accepted and ready to land.Dec 9 2022, 7:11 AM

markj accepted this revision as: markj.Dec 9 2022, 3:59 PM

Closed by commit rG91980db1beec: vmm: Don't lock a vCPU for VM_PPTDEV_MSI[X]. (authored by jhb). · Explain WhyDec 9 2022, 6:32 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG91980db1beec: vmm: Don't lock a vCPU for VM_PPTDEV_MSI[X]..

jhb added a commit: rG3bedbb1008a8: vmm: Don't lock a vCPU for VM_PPTDEV_MSI[X]..Jan 26 2023, 10:18 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

include/

vmm_dev.h

4 lines

vmm/

vmm_dev.c

2 lines

Diff 113959

View Options

sys/amd64/include/vmm_dev.h