Page MenuHomeFreeBSD
Differential D37651

bhyve: Pass a vCPU ID of 0 to vm_setup_pptdev_msi*.
ClosedPublic
Actions

Authored by jhb on Dec 9 2022, 12:59 AM.
Tags
None
Referenced Files
F166092260: D37651.diff
Tue, Aug 11, 4:11 PM
Unknown Object (File)
Sun, Aug 9, 3:04 PM
Unknown Object (File)
Sun, Aug 9, 2:14 AM
Unknown Object (File)
Sat, Aug 8, 3:04 PM
Unknown Object (File)
Fri, Aug 7, 7:43 PM
Unknown Object (File)
Fri, Aug 7, 5:14 PM
Unknown Object (File)
Fri, Aug 7, 4:21 PM
Unknown Object (File)
Sun, Jul 26, 11:57 PM
View All Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
markj
corvink
Group Reviewers
bhyve
Commits
rG8506352dd517: bhyve: Pass a vCPU ID of 0 to vm_setup_pptdev_msi*.
rG0857e5555d77: bhyve: Pass a vCPU ID of 0 to vm_setup_pptdev_msi*.
Summary

These ioctls are not vCPU-specific and the ioctl now ignores the vCPU
ID. 0 is used instead of -1 to provide limited forwards
compatibility.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Dec 9 2022, 12:59 AM
Herald added a reviewer: bhyve. · View Herald TranscriptDec 9 2022, 12:59 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
jhb requested review of this revision.Dec 9 2022, 12:59 AM
Harbormaster completed remote builds in B48671: Diff 113971.Dec 9 2022, 1:00 AM
jhb added a child revision: D37652: bhyve: Remove unused vcpu argument from PCI read/write methods..Dec 9 2022, 1:00 AM
jhb added a parent revision: D37639: vmm: Don't lock a vCPU for VM_PPTDEV_MSI[X]..Dec 9 2022, 1:02 AM
corvink accepted this revision.Dec 9 2022, 7:28 AM
This revision is now accepted and ready to land.Dec 9 2022, 7:28 AM
markj accepted this revision as: markj.Dec 9 2022, 4:10 PM
markj added inline comments.
usr.sbin/bhyve/pci_passthru.c
951

This line is too long.

jhb added inline comments.Dec 9 2022, 6:30 PM
usr.sbin/bhyve/pci_passthru.c
951

Hmm, this one is 79 characters long (and the vcpu gets removed in a followup).

1031–1032

But this one is indeed long.

Closed by commit rG0857e5555d77: bhyve: Pass a vCPU ID of 0 to vm_setup_pptdev_msi*. (authored by jhb). · Explain WhyDec 9 2022, 6:32 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG0857e5555d77: bhyve: Pass a vCPU ID of 0 to vm_setup_pptdev_msi*..
jhb added a commit: rG8506352dd517: bhyve: Pass a vCPU ID of 0 to vm_setup_pptdev_msi*..Jan 26 2023, 10:35 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
16 lines

Diff 114011

View Options

usr.sbin/bhyve/pci_passthru.c

Loading...