netmap tests: Reset ctx->nmctx to NULL in nmreq_parsing.
ClosedPublic
Actions

Authored by jhb on Nov 29 2022, 7:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 4, 12:58 AM

	Unknown Object (File)
	Sun, Oct 4, 12:30 AM

	Unknown Object (File)
	Sat, Oct 3, 11:25 PM

	Unknown Object (File)
	Thu, Sep 10, 4:02 AM

	Unknown Object (File)
	Mon, Sep 7, 11:27 AM

	Unknown Object (File)
	Sep 6 2026, 9:26 AM

	Unknown Object (File)
	Sep 5 2026, 2:07 PM

	Unknown Object (File)
	Sep 5 2026, 1:51 PM

View All Files

Subscribers

glebius

melifaro

Details

Reviewers

emaste
imp

Commits

rGf4db390553ba: netmap tests: Reset ctx->nmctx to NULL in nmreq_parsing.

Summary

This avoids leaking a pointer to the on-stack test_nmctx which
triggers a -Wdangling-pointer warning from GCC.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 29 2022, 7:51 PM

Herald added subscribers: glebius, melifaro. · View Herald TranscriptNov 29 2022, 7:51 PM

jhb requested review of this revision.Nov 29 2022, 7:51 PM

Harbormaster completed remote builds in B48537: Diff 113623.Nov 29 2022, 7:51 PM

jhb added a parent revision: D37535: acpica: Quiet a -Wdangling-pointer warning in AcpiUtInitStackPtrTrace..Nov 29 2022, 7:51 PM

imp accepted this revision.Nov 29 2022, 8:15 PM

This revision is now accepted and ready to land.Nov 29 2022, 8:15 PM

emaste accepted this revision.Nov 29 2022, 9:55 PM

Closed by commit rGf4db390553ba: netmap tests: Reset ctx->nmctx to NULL in nmreq_parsing. (authored by jhb). · Explain WhyDec 5 2022, 12:30 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGf4db390553ba: netmap tests: Reset ctx->nmctx to NULL in nmreq_parsing..

Revision Contents
Changeset List

Path

Size

tests/

sys/

netmap/

ctrl-api-test.c

1 line

Diff 113812

View Options

tests/sys/netmap/ctrl-api-test.c

netmap tests: Reset ctx->nmctx to NULL in nmreq_parsing.ClosedPublicActions