Page MenuHomeFreeBSD

libsa: Disable -Wdangling-pointer for zfs.c.
ClosedPublic

Authored by jhb on Nov 29 2022, 7:50 PM.
Tags
None
Referenced Files
F81675660: D37533.diff
Fri, Apr 19, 6:43 PM
Unknown Object (File)
Mar 16 2024, 12:52 AM
Unknown Object (File)
Mar 16 2024, 12:52 AM
Unknown Object (File)
Mar 16 2024, 12:52 AM
Unknown Object (File)
Mar 12 2024, 5:39 AM
Unknown Object (File)
Dec 20 2023, 5:21 AM
Unknown Object (File)
Nov 27 2023, 8:57 AM
Unknown Object (File)
Nov 26 2023, 7:01 AM
Subscribers

Details

Summary

GCC 12 warns about a dangling pointer to 'objid' in
zfs_bootenv_initial(). However, this appears to be a false positive
as the pointer to 'objid' is only passed to zfs_lookup_dataset() but
not saved anywhere that outlives the lifetime of the
zfs_bootenv_initial() function.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Nov 29 2022, 7:50 PM
This revision is now accepted and ready to land.Nov 29 2022, 8:14 PM

Is it worth mentioning the false positive in a src comment?

Is it worth mentioning the false positive in a src comment?

I think the ZFS code is the vendor OpenZFS code so would be a local diff, so probably not.

This revision was automatically updated to reflect the committed changes.