Page MenuHomeFreeBSD

libsa: Disable -Wdangling-pointer for zfs.c.
ClosedPublic

Authored by jhb on Nov 29 2022, 7:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 9, 12:36 PM
Unknown Object (File)
Sun, Jan 8, 12:33 AM
Unknown Object (File)
Sat, Jan 7, 3:18 PM
Unknown Object (File)
Dec 14 2022, 3:22 AM
Unknown Object (File)
Dec 5 2022, 10:56 PM
Subscribers

Details

Summary

GCC 12 warns about a dangling pointer to 'objid' in
zfs_bootenv_initial(). However, this appears to be a false positive
as the pointer to 'objid' is only passed to zfs_lookup_dataset() but
not saved anywhere that outlives the lifetime of the
zfs_bootenv_initial() function.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Nov 29 2022, 7:50 PM
This revision is now accepted and ready to land.Nov 29 2022, 8:14 PM

Is it worth mentioning the false positive in a src comment?

Is it worth mentioning the false positive in a src comment?

I think the ZFS code is the vendor OpenZFS code so would be a local diff, so probably not.

This revision was automatically updated to reflect the committed changes.