Page MenuHomeFreeBSD

Miscellaneous small changes to the Committer's Guide.
ClosedPublic

Authored by pauamma_gundo.com on Oct 22 2022, 6:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 29, 6:59 AM
Unknown Object (File)
Jan 18 2024, 3:01 AM
Unknown Object (File)
Jan 12 2024, 10:46 AM
Unknown Object (File)
Dec 20 2023, 7:48 AM
Unknown Object (File)
Dec 8 2023, 5:19 AM
Unknown Object (File)
Nov 15 2023, 6:12 PM
Unknown Object (File)
Nov 7 2023, 9:14 AM
Unknown Object (File)
Nov 6 2023, 5:15 PM
Subscribers

Details

Summary

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261812

Plus a few more I spotted while working on it.

Test Plan

make all
Eyeball lynx output.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 47959
Build 44846: arc lint + arc unit

Event Timeline

pauamma_gundo.com created this revision.

Noting that I can't read /home/portmgr/public, so I can't verify the full pathname for those reports is still correct.

This revision is now accepted and ready to land.Oct 24 2022, 1:21 PM

gitrepo.freebsd.org has been canonicalized to repo.freebsd.org. …

There remain uses of gitrepo, is this intended?

Sorry for the late feedback.

gitrepo.freebsd.org has been canonicalized to repo.freebsd.org. …

There remain uses of gitrepo, is this intended?

I didn't intend to change uses of it in the text, if that's what you're asking. Whether they should be changed is more than I can say. All this is saying is what happened in DNS. Should I make that explicit?

In D37091#842794, @pauamma wrote:

… Whether they should be changed is more than I can say.

"… the future is now. …", so if not amongst this round of edits, we can update the text in the next round.

(I don't want to complicate this review for you.)

All this is saying is what happened in DNS. Should I make that explicit?

I think, simply:

  • change things to use what's now correct for the primary source of truth i.e. repo.FreeBSD.org
  • don't use the Guide to describe the reason for change.

(I still prefer lowercase repo.freebsd.org, but that's a conversation for another day.)

If a committer becomes curious about what happened to gitrepo.freebsd.org, it'll be easy enough for the person to find the explanation.

NTS: portmgr reports are again readable.

Looks good.

documentation/content/en/articles/committers-guide/_index.adoc
92

I think these locations should spell out freefall rather than FreeBSD.org cluster. This information probably dates back to when we had NFS mounts to machine-whose-name-we-do-not-speak all over the cluster.

180

Does a more authoritative source exist than some individual's personal diary?

documentation/content/en/articles/committers-guide/_index.adoc
180

Probably, but I'm unable to evaluate those claims. Implied question ("which authoritative sources discuss key sizes?") is beyond me. All I can suggest is removing the link if deemed too unreliable.

  • Address philip's comments.
  • While there, check nearby URLs still work and use https:.
This revision now requires review to proceed.Dec 1 2022, 9:43 PM
This revision is now accepted and ready to land.Dec 2 2022, 4:02 AM

*ping mentors* (for the latest version)