crypto: Remove all uses of CRYPTO_F_DONE

[markj]

Summary

This flag is not very useful and has no consumers. Leave the flag
definition for now to allow old OpenZFS to compile without a version
bump.

[pauamma_gundo.com]

share/man/man9/crypto_request.9

476–486

Perhaps better, to match the comment in sys/opencrypto/cryptodev.h?

[jhb]

I think it's fine if we leave the flag undocumented. I suspect we can remove it outright before 14.0 ships. We should perhaps mark it as deprecated in 13.x though and update the documentation to say that in 13?

[markj]

In D36252#824847, @jhb wrote:

We should perhaps mark it as deprecated in 13.x though and update the documentation to say that in 13?

The documentation (in stable/13) already says, "This flag is not very useful and will likely be removed in the future." Do you think that's sufficient?

share/man/man9/crypto_request.9

476–486

The flag is only still defined because OpenZFS sources reference it. Since it's just there to provide source compatibility, I think it's better to leave it undocumented. It will be removed outright soon enough.

[jhb]

In D36252#824857, @markj wrote:

In D36252#824847, @jhb wrote:

We should perhaps mark it as deprecated in 13.x though and update the documentation to say that in 13?

The documentation (in stable/13) already says, "This flag is not very useful and will likely be removed in the future." Do you think that's sufficient?

Oh, hah, I guess I already had a dim view of it then. Yes, I think that's fine. Maybe we adjust the comment to say it is has been removed in 14 as a direct commit to stable/13 just to be clear?

[pauamma_gundo.com]

share/man/man9/crypto_request.9

476–486

OK then.