Page MenuHomeFreeBSD

intrng: Remove irq_root_ipicount and corresponding intr_pic_claim_root arg
ClosedPublic

Authored by jrtc27 on Jul 24 2022, 9:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 3:35 PM
Unknown Object (File)
Thu, Nov 21, 3:35 PM
Unknown Object (File)
Thu, Nov 21, 3:35 PM
Unknown Object (File)
Thu, Nov 21, 3:35 PM
Unknown Object (File)
Wed, Nov 20, 9:04 AM
Unknown Object (File)
Fri, Nov 8, 9:16 PM
Unknown Object (File)
Fri, Nov 8, 7:43 PM
Unknown Object (File)
Fri, Nov 8, 7:38 PM

Details

Summary

The static irq_root_ipicount variable is only ever written to (with the
value passed to irq_root_ipicount), never read. Moreover, the bcm2836
driver, as used by the Raspberry Pi 2B and 3A/B (but not 4, which uses a
GIC-400, though does have the legacy interrupt controller present too)
passes 0 as ipicount, despite implementing IPIs. It's thus inaccurate
and serves no purpose, so should be removed.

MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 24 2022, 9:59 PM

should these values be needed in the future, we can revert this commit as part of that work (while correcting the issue identified).
this has been around for a while, though, w/o needing it, so I think it's OK.

This revision now requires review to proceed.Jan 19 2024, 8:44 PM
This revision is now accepted and ready to land.Jan 22 2024, 3:53 PM