loader: Set preferred kenv for acpi.rsdp on arm64
ClosedPublic
Actions

Authored by imp on Jun 28 2022, 6:11 PM.

Details

Reviewers

manu
andrew
jhb

Commits

rG29edd79482f1: loader: Set preferred kenv for acpi.rsdp on arm64
rG37a3df3d6162: loader: Set preferred kenv for acpi.rsdp on arm64

Summary

Several years ago, x86 moved from using hints to communicate this
information to using the simpler acpi.rsdp variables. If one compiles
static hints into the kernel, then these hints are ignored. We can
remove this when we branch FreeBSD 15.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jun 28 2022, 6:11 PM

Herald added a reviewer: manu. · View Herald TranscriptJun 28 2022, 6:11 PM

Herald added subscribers: dab, bcran, emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B46160: Diff 107492.Jun 28 2022, 6:11 PM

imp requested review of this revision.Jun 28 2022, 6:11 PM

imp added a parent revision: D35631: arm64: Grab the RSDP from acpi.rsdp like x86.

imp added a child revision: D35633: amd64/efi: Stop falling back to hints for RSDP.

imp added reviewers: andrew, jhb.Jun 28 2022, 6:12 PM

andrew accepted this revision.Jun 29 2022, 2:46 PM

andrew added inline comments.

stand/efi/loader/arch/arm64/exec.c
86	There is no BIOS on arm64 so the second sentence could be removed.

This revision is now accepted and ready to land.Jun 29 2022, 2:46 PM

jhb accepted this revision.Jun 30 2022, 6:23 PM

Closed by commit rG37a3df3d6162: loader: Set preferred kenv for acpi.rsdp on arm64 (authored by imp). · Explain WhyJul 2 2022, 2:05 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG37a3df3d6162: loader: Set preferred kenv for acpi.rsdp on arm64.

imp added a commit: rG29edd79482f1: loader: Set preferred kenv for acpi.rsdp on arm64.Jan 24 2023, 10:22 PM

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

arch/

arm64/

exec.c

15 lines

Diff 107676

View Options

stand/efi/loader/arch/arm64/exec.c

loader: Set preferred kenv for acpi.rsdp on arm64ClosedPublicActions