Page MenuHomeFreeBSD
Differential D35074

Add MODULE_PNP_INFO() to rtsx
ClosedPublic
Actions

Authored by hlh_restart.be on Apr 27 2022, 12:41 PM.
Tags
None
Referenced Files
F81951488: D35074.id105476.diff
Tue, Apr 23, 4:24 PM
Unknown Object (File)
Fri, Apr 5, 10:50 PM
Unknown Object (File)
Fri, Apr 5, 10:50 PM
Unknown Object (File)
Fri, Apr 5, 10:50 PM
Unknown Object (File)
Fri, Apr 5, 10:50 PM
Unknown Object (File)
Fri, Apr 5, 10:50 PM
Unknown Object (File)
Fri, Mar 29, 10:23 AM
Unknown Object (File)
Jan 26 2024, 11:53 PM
View All 47 Files
Subscribers
imp
mhorne

Details

Reviewers
jkim
mav
imp
Commits
rG71883128e5c8: rtsx: Add plug-and-play info
Summary

Add MODULE_PNP_INFO() to the driver to make it autoload if not linked statically into the kernel

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hlh_restart.be created this revision.Apr 27 2022, 12:41 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 27 2022, 12:41 PM
hlh_restart.be requested review of this revision.Apr 27 2022, 12:41 PM
Harbormaster completed remote builds in B45388: Diff 105454.Apr 27 2022, 12:41 PM
mhorne added a subscriber: mhorne.Apr 27 2022, 3:02 PM

Nice to see this. Perhaps a follow-up change removing rtsx from amd64/i386 GENERIC configs would be appropriate?

hlh_restart.be updated this revision to Diff 105476.Apr 27 2022, 5:20 PM

Comment rtsx device in GENERIC

Harbormaster completed remote builds in B45402: Diff 105476.Apr 27 2022, 5:20 PM
mav added inline comments.Apr 27 2022, 5:26 PM
sys/dev/rtsx/rtsx.c
3922

It would be better to reuse the list from main probe function above without duplication. I haven't looked closer into the format string of the macro, but I think it should be possible.

sys/i386/conf/GENERIC
321–322

I wonder whether anybody use rtsx as boot device. I know that some systems use MMC cards as one, that is why we have sdhci in GENERIC.

hlh_restart.be updated this revision to Diff 105486.Apr 27 2022, 7:26 PM

reuse the list from main probe function for MODULE_PNP_INFO()

Harbormaster completed remote builds in B45407: Diff 105486.Apr 27 2022, 7:26 PM
hlh_restart.be marked an inline comment as done.Apr 27 2022, 7:30 PM
hlh_restart.be added inline comments.
sys/i386/conf/GENERIC
321–322

I don't think this is frequent. I try it on my ACER to no avail.

hlh_restart.be updated this revision to Diff 106255.May 22 2022, 8:27 AM

Add ThinkPad X13 Gen 1 into inversion models

Harbormaster completed remote builds in B45663: Diff 106255.May 22 2022, 8:27 AM
hlh_restart.be updated this revision to Diff 116519.Feb 5 2023, 11:25 AM
  • Remove support for FreeBSD 11 and earlier
Harbormaster completed remote builds in B49533: Diff 116519.Feb 5 2023, 11:25 AM
imp added inline comments.Feb 5 2023, 3:57 PM
sys/dev/rtsx/rtsx.c
3908

Does this work? I didn't think that you could specify vendor= like this. I can't seem to find the code that parses it like that, can you help me find what I'm overlooking?

hlh_restart.be added inline comments.Feb 5 2023, 4:48 PM
sys/dev/rtsx/rtsx.c
3908

I test it at every boot on my laptop.

I follow
Example 2: Using T for common vendor value
in man MODULE_PNP_INFO

imp accepted this revision.Feb 5 2023, 6:01 PM
imp added inline comments.
sys/dev/rtsx/rtsx.c
3908

Ah, indeed. I'd forgotten about T.
Then this looks good to me.

This revision is now accepted and ready to land.Feb 5 2023, 6:01 PM
mhorne added inline comments.Feb 6 2023, 2:00 PM
sys/amd64/conf/GENERIC
366–367

I think you should pick between keeping the device in GENERIC or removing the line completely, rather than commenting it out.

hlh_restart.be updated this revision to Diff 116573.Feb 6 2023, 2:38 PM
  • Remove rtsx from amd64 and i386 GENERIC configuration
This revision now requires review to proceed.Feb 6 2023, 2:38 PM
Harbormaster completed remote builds in B49567: Diff 116573.Feb 6 2023, 2:38 PM
hlh_restart.be marked 2 inline comments as done.Feb 6 2023, 2:41 PM
hlh_restart.be added inline comments.
sys/amd64/conf/GENERIC
366–367

removed

sys/i386/conf/GENERIC
321–322

removed

mhorne added inline comments.Feb 6 2023, 2:41 PM
sys/amd64/conf/GENERIC
366–367

Thanks!

hlh_restart.be marked an inline comment as done.Apr 9 2023, 9:38 AM

Hello,

Now that 13.2-RELEASE is almost done I think it would be nice to have this update committed for 14.0-RELEASE.
With the PNP, the kernel is smaller for the configuration without Realtek.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 13 2023, 2:14 PM
Closed by commit rG71883128e5c8: rtsx: Add plug-and-play info (authored by hlh_restart.be, committed by mhorne). · Explain Why
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG71883128e5c8: rtsx: Add plug-and-play info.

Revision Contents
Changeset List

PathSize
sys/
amd64/
conf/
1 line
dev/
rtsx/
49 lines
i386/
conf/
1 line

Diff 120260

View Options

sys/amd64/conf/GENERIC

Loading...
View Options

sys/dev/rtsx/rtsx.c

Loading...
View Options

sys/i386/conf/GENERIC

Loading...