Page MenuHomeFreeBSD

Add MODULE_PNP_INFO() to rtsx
ClosedPublic

Authored by hlh_restart.be on Apr 27 2022, 12:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 26 2024, 11:53 PM
Unknown Object (File)
Jan 26 2024, 11:53 PM
Unknown Object (File)
Jan 26 2024, 11:53 PM
Unknown Object (File)
Jan 26 2024, 11:53 PM
Unknown Object (File)
Jan 26 2024, 11:53 PM
Unknown Object (File)
Jan 4 2024, 1:25 PM
Unknown Object (File)
Jan 4 2024, 3:46 AM
Unknown Object (File)
Dec 23 2023, 1:49 PM
Subscribers

Details

Summary

Add MODULE_PNP_INFO() to the driver to make it autoload if not linked statically into the kernel

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45402
Build 42290: arc lint + arc unit

Event Timeline

Nice to see this. Perhaps a follow-up change removing rtsx from amd64/i386 GENERIC configs would be appropriate?

sys/dev/rtsx/rtsx.c
3928

It would be better to reuse the list from main probe function above without duplication. I haven't looked closer into the format string of the macro, but I think it should be possible.

sys/i386/conf/GENERIC
322

I wonder whether anybody use rtsx as boot device. I know that some systems use MMC cards as one, that is why we have sdhci in GENERIC.

reuse the list from main probe function for MODULE_PNP_INFO()

hlh_restart.be added inline comments.
sys/i386/conf/GENERIC
322

I don't think this is frequent. I try it on my ACER to no avail.

Add ThinkPad X13 Gen 1 into inversion models

  • Remove support for FreeBSD 11 and earlier
sys/dev/rtsx/rtsx.c
3914

Does this work? I didn't think that you could specify vendor= like this. I can't seem to find the code that parses it like that, can you help me find what I'm overlooking?

sys/dev/rtsx/rtsx.c
3914

I test it at every boot on my laptop.

I follow
Example 2: Using T for common vendor value
in man MODULE_PNP_INFO

imp added inline comments.
sys/dev/rtsx/rtsx.c
3914

Ah, indeed. I'd forgotten about T.
Then this looks good to me.

This revision is now accepted and ready to land.Feb 5 2023, 6:01 PM
sys/amd64/conf/GENERIC
366

I think you should pick between keeping the device in GENERIC or removing the line completely, rather than commenting it out.

  • Remove rtsx from amd64 and i386 GENERIC configuration
This revision now requires review to proceed.Feb 6 2023, 2:38 PM
hlh_restart.be added inline comments.
sys/amd64/conf/GENERIC
366

removed

sys/i386/conf/GENERIC
322

removed

sys/amd64/conf/GENERIC
366

Thanks!

Hello,

Now that 13.2-RELEASE is almost done I think it would be nice to have this update committed for 14.0-RELEASE.
With the PNP, the kernel is smaller for the configuration without Realtek.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 13 2023, 2:14 PM
Closed by commit rG71883128e5c8: rtsx: Add plug-and-play info (authored by hlh_restart.be, committed by mhorne). · Explain Why
This revision was automatically updated to reflect the committed changes.