Page MenuHomeFreeBSD

Add MODULE_PNP_INFO() to rtsx
Needs ReviewPublic

Authored by hlh_restart.be on Apr 27 2022, 12:41 PM.

Details

Reviewers
jkim
mav
Summary

Add MODULE_PNP_INFO() to the driver to make it autoload if not linked statically into the kernel

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 45402
Build 42290: arc lint + arc unit

Event Timeline

Nice to see this. Perhaps a follow-up change removing rtsx from amd64/i386 GENERIC configs would be appropriate?

sys/dev/rtsx/rtsx.c
3928

It would be better to reuse the list from main probe function above without duplication. I haven't looked closer into the format string of the macro, but I think it should be possible.

sys/i386/conf/GENERIC
322

I wonder whether anybody use rtsx as boot device. I know that some systems use MMC cards as one, that is why we have sdhci in GENERIC.

reuse the list from main probe function for MODULE_PNP_INFO()

hlh_restart.be added inline comments.
sys/i386/conf/GENERIC
322

I don't think this is frequent. I try it on my ACER to no avail.

Add ThinkPad X13 Gen 1 into inversion models