getdirentries: return ENOENT for unlinked but still open directory.

[dchagin]

Summary

To be more compliant to IEEE Std 1003.1-2008 (“POSIX.1”)

[mjg]

sys/kern/vfs_syscalls.c

3960

rmdir might have failed, but also this is not the place to do it. it should be in vop_rmdir_post

[mjg]

sys/kern/vfs_syscalls.c

3960

the flag itself is only used by gjournal, so a new one would have to be introduced for this purpose (VV_UNLINKED?)

[pauamma_gundo.com]

Other than that, English LGTM. Can't vouch for content.

lib/libc/sys/getdirentries.2

197

I'd be more specific here, maybe by repeating "unlinked but still open directory".

Also, while touching this area, I'd mention that getdents() has the same errno values (if it does).

[dchagin]

Thanks!

[mjg]

sys/kern/vfs_subr.c

5987

again you need to error check -- move it into the !rc case

[mjg]

sys/kern/vfs_syscalls.c

4198

i guess __predict_false on this would not hurt

[dchagin]

ah, fixed, thank you, Mateusz