cleanup of rack variables
ClosedPublic
Actions

Authored by rrs on Feb 8 2022, 3:42 PM.

Details

Reviewers

tuexen
rscheff
gallatin

Group Reviewers

transport

Commits

rG8d64b4b4c450: cleanup of rack variables.

Summary

During a recent deep dive into all the variables so I could
discover why stack switching caused larger retransmits I examined
every variable in rack. In the process I found quite a few bits
that were not used and needed cleanup. This update pulls
out all the unused pieces from rack. Note there are *no* functional
changes here, just the removal of unused variables and a bit of
spacing clean up.

Test Plan

Make sure it compiles after removing the unused variables.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rrs created this revision.Feb 8 2022, 3:42 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptFeb 8 2022, 3:42 PM

Herald added subscribers: glebius, melifaro. · View Herald Transcript

rrs requested review of this revision.Feb 8 2022, 3:42 PM

rrs edited the summary of this revision. (Show Details)

gallatin added inline comments.Feb 8 2022, 3:57 PM

sys/netinet/tcp_stacks/rack.c
13306	Is this (and the next hunk) a functional change?

the cleanup of the debug/troubleshooting/dev variable looks largely fine to me.

Any plans to backport this to stable/13 or has the rack code diverged too much to not be worthwhile (hystart is specific to main, so if no MFC is planned, I am ok with the minor changes there in one diff).

tuexen accepted this revision.Feb 8 2022, 6:04 PM

This revision is now accepted and ready to land.Feb 8 2022, 6:04 PM

Rack has diverged so much from 13 that I would not even
attempt to backport this.

Closed by commit rG8d64b4b4c450: cleanup of rack variables. (authored by rrs). · Explain WhyFeb 9 2022, 9:10 PM

This revision was automatically updated to reflect the committed changes.

rrs added a commit: rG8d64b4b4c450: cleanup of rack variables..

Herald added a subscriber: imp. · View Herald TranscriptFeb 9 2022, 9:10 PM