Page MenuHomeFreeBSD

dummynet: don't use per-vnet locks to protect global data.
ClosedPublic

Authored by kp on Jan 27 2022, 10:48 AM.
Tags
None
Referenced Files
F83975911: D34059.id102479.diff
Fri, May 17, 4:43 PM
Unknown Object (File)
Sat, May 11, 8:42 PM
Unknown Object (File)
Fri, May 10, 3:44 AM
Unknown Object (File)
Apr 3 2024, 1:13 AM
Unknown Object (File)
Jan 15 2024, 10:50 AM
Unknown Object (File)
Dec 23 2023, 1:17 AM
Unknown Object (File)
Dec 21 2023, 7:13 AM
Unknown Object (File)
Dec 10 2023, 9:18 PM

Details

Summary

The ref_count counter is global (i.e. not per-vnet) so we can't use a
per-vnet lock to protect it. Moreover, in callouts curvnet is not set,
so we'd end up panicing when trying to use DN_BH_WLOCK().

Instead we use the global sched_lock, which is already used when
evaluating ref_count (in unload_dn_aqm()).

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable