Page MenuHomeFreeBSD

dummynet: don't use per-vnet locks to protect global data.
ClosedPublic

Authored by kp on Jan 27 2022, 10:48 AM.
Tags
None
Referenced Files
F166524332: D34059.diff
Fri, Aug 14, 12:48 AM
F166422057: D34059.id101989.diff
Thu, Aug 13, 12:34 PM
F166422001: D34059.id102479.diff
Thu, Aug 13, 12:34 PM
F166421631: D34059.diff
Thu, Aug 13, 12:32 PM
Unknown Object (File)
Tue, Aug 11, 10:40 PM
Unknown Object (File)
Sun, Aug 9, 5:54 PM
Unknown Object (File)
Fri, Aug 7, 7:01 PM
Unknown Object (File)
Wed, Aug 5, 2:19 AM

Details

Summary

The ref_count counter is global (i.e. not per-vnet) so we can't use a
per-vnet lock to protect it. Moreover, in callouts curvnet is not set,
so we'd end up panicing when trying to use DN_BH_WLOCK().

Instead we use the global sched_lock, which is already used when
evaluating ref_count (in unload_dn_aqm()).

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable