Page MenuHomeFreeBSD

Make struct syscall_args machine independent
ClosedPublic

Authored by brooks on Dec 6 2021, 10:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 30, 9:20 AM
Unknown Object (File)
Sun, Jun 30, 9:17 AM
Unknown Object (File)
Sat, Jun 29, 7:37 AM
Unknown Object (File)
Sat, Jun 29, 12:50 AM
Unknown Object (File)
Mon, Jun 24, 11:49 PM
Unknown Object (File)
Sat, Jun 15, 11:43 PM
Unknown Object (File)
Mar 7 2024, 4:37 PM
Unknown Object (File)
Feb 6 2024, 9:58 AM

Details

Summary

After a round of cleanups in late 2020, all definitions are
functionally identical.

This removes a rotted __aligned(8) on arm. It was added in
b7112ead32bc50ef9744099bdbb1cfbd6e906b2a and was intended to align the
args member so that 64-bit types (off_t, etc) could be safely read on
armeb compiled with clang. With the removal of armev, this is no
longer needed (armv7 requires that 32-bit aligned reads of 64-bit
values be supported and we enable such support on armv6). As further
evidence this is unnecessary, cleanups to struct syscall_args have
resulted in args being 32-bit aligned on 32-bit systems. The sole
effect is to bloat the struct by 4 bytes.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib added inline comments.
sys/sys/proc.h
204

I believe MAXARGS definition should be removed in this change, or in immediate follow-up. It seems there are only two uses of the symbol in arm64 MD code, everything else uses nitems(sa->args).

This revision is now accepted and ready to land.Dec 6 2021, 11:00 PM
brooks added inline comments.
sys/sys/proc.h
204

While I'm not generally a fan of magic numbers this makes sense. I'll work that up.