Page MenuHomeFreeBSD

bhyve blockif: fix blockif_candelete with Capsicum
ClosedPublic

Authored by chuck on Nov 30 2021, 7:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 12:14 AM
Unknown Object (File)
Fri, Dec 20, 2:22 PM
Unknown Object (File)
Wed, Dec 4, 9:58 PM
Unknown Object (File)
Wed, Dec 4, 9:57 PM
Unknown Object (File)
Wed, Dec 4, 9:57 PM
Unknown Object (File)
Wed, Dec 4, 9:37 PM
Unknown Object (File)
Sun, Dec 1, 2:11 PM
Unknown Object (File)
Nov 15 2024, 5:20 PM

Details

Summary

NVMe conformance tests for the Format command failed if the
backing-storage for the bhyve device was a file instead of a Zvol. The
tests (and the specification) expect a Format to destroy all previously
written data. The bhyve NVMe emulation implements this by trimming /
deallocating all data from the backing-storage.

The blockif_candelete() function indicated the file did not support
deallocation (i.e. fpathconf(..., _PC_DEALLOC_PRESENT) returned FALSE)
even though the kernel supported file hole punching. This occurs on
builds with Capsicum enabled because blockif did not allow the
fpathconf(2) right.

Fix is to add CAP_FPATHCONF to the cap_rights_init(3) call.

PR: 260081

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43067
Build 39955: arc lint + arc unit