Page MenuHomeFreeBSD

bhyve blockif: fix blockif_candelete with Capsicum
ClosedPublic

Authored by chuck on Nov 30 2021, 7:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 23 2024, 10:19 AM
Unknown Object (File)
Dec 22 2023, 10:25 PM
Unknown Object (File)
Nov 22 2023, 8:41 PM
Unknown Object (File)
Nov 21 2023, 5:58 AM
Unknown Object (File)
Nov 15 2023, 12:07 PM
Unknown Object (File)
Nov 13 2023, 9:12 AM
Unknown Object (File)
Oct 24 2023, 4:39 PM
Unknown Object (File)
Sep 17 2023, 1:54 PM

Details

Summary

NVMe conformance tests for the Format command failed if the
backing-storage for the bhyve device was a file instead of a Zvol. The
tests (and the specification) expect a Format to destroy all previously
written data. The bhyve NVMe emulation implements this by trimming /
deallocating all data from the backing-storage.

The blockif_candelete() function indicated the file did not support
deallocation (i.e. fpathconf(..., _PC_DEALLOC_PRESENT) returned FALSE)
even though the kernel supported file hole punching. This occurs on
builds with Capsicum enabled because blockif did not allow the
fpathconf(2) right.

Fix is to add CAP_FPATHCONF to the cap_rights_init(3) call.

PR: 260081

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable