Page MenuHomeFreeBSD

bhyve blockif: fix blockif_candelete with Capsicum
ClosedPublic

Authored by chuck on Nov 30 2021, 7:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 10, 4:53 PM
Unknown Object (File)
Wed, Sep 9, 8:44 AM
Unknown Object (File)
Sun, Sep 6, 2:21 AM
Unknown Object (File)
Sat, Sep 5, 3:52 AM
Unknown Object (File)
Fri, Sep 4, 6:46 PM
Unknown Object (File)
Thu, Sep 3, 12:00 PM
Unknown Object (File)
Wed, Sep 2, 8:38 PM
Unknown Object (File)
Wed, Sep 2, 8:18 PM

Details

Summary

NVMe conformance tests for the Format command failed if the
backing-storage for the bhyve device was a file instead of a Zvol. The
tests (and the specification) expect a Format to destroy all previously
written data. The bhyve NVMe emulation implements this by trimming /
deallocating all data from the backing-storage.

The blockif_candelete() function indicated the file did not support
deallocation (i.e. fpathconf(..., _PC_DEALLOC_PRESENT) returned FALSE)
even though the kernel supported file hole punching. This occurs on
builds with Capsicum enabled because blockif did not allow the
fpathconf(2) right.

Fix is to add CAP_FPATHCONF to the cap_rights_init(3) call.

PR: 260081

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable