linux_linkat: Don't invert AT_* flags.
ClosedPublic
Actions

Authored by jhb on Nov 17 2021, 10:43 PM.

Details

Reviewers

trasz
kib

Commits

rGfd1b7d25194a: linux_linkat: Don't invert AT_* flags.
rGa8d885296a9d: linux_linkat: Don't invert AT_* flags.

Summary

Sponsored by: The University of Cambridge, Google Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 17 2021, 10:43 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 17 2021, 10:43 PM

jhb requested review of this revision.Nov 17 2021, 10:43 PM

Harbormaster completed remote builds in B42854: Diff 98665.Nov 17 2021, 10:43 PM

jhb added a child revision: D33049: linux_name_to_handle_at: Use AT_SYMLINK_FOLLOW to simplify logic..Nov 17 2021, 10:43 PM

I noticed this when merging in changes to CheriBSD where I had done a local commit to push down AT_* flags into kern_linkat() before merging the upstream change. Note that neither this nor the two followup reviews are runtime tested, only compile tested.

kib accepted this revision.Nov 17 2021, 10:54 PM

This revision is now accepted and ready to land.Nov 17 2021, 10:54 PM

Closed by commit rGa8d885296a9d: linux_linkat: Don't invert AT_* flags. (authored by jhb). · Explain WhyNov 18 2021, 12:05 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGa8d885296a9d: linux_linkat: Don't invert AT_* flags..

dchagin added a commit: rGfd1b7d25194a: linux_linkat: Don't invert AT_* flags..Jun 17 2022, 7:40 PM