Page MenuHomeFreeBSD

LinuxKPI: Import some linux/rbtree.h functions from OpenBSD
ClosedPublic

Authored by wulf on Nov 6 2021, 10:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 5:33 PM
Unknown Object (File)
Mar 7 2024, 11:56 PM
Unknown Object (File)
Jan 13 2024, 12:49 AM
Unknown Object (File)
Dec 28 2023, 1:18 PM
Unknown Object (File)
Dec 23 2023, 2:30 AM
Unknown Object (File)
Oct 20 2023, 10:53 AM
Unknown Object (File)
Oct 19 2023, 11:48 AM
Unknown Object (File)
Sep 14 2023, 11:51 AM

Details

Summary

and implement interval_tree

Required by drm-kmod

MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf requested review of this revision.Nov 6 2021, 10:28 AM
This revision is now accepted and ready to land.Nov 6 2021, 3:28 PM
gbe added inline comments.
sys/compat/linuxkpi/common/include/linux/interval_tree.h
5

When these functions are imported from OpenBSD, should that be somewhere noticed in the copyright statement?

sys/compat/linuxkpi/common/include/linux/interval_tree_generic.h
5

When these functions are imported from OpenBSD, should that be somewhere noticed in the copyright statement?

sys/compat/linuxkpi/common/include/linux/interval_tree.h
5

When these functions are imported from OpenBSD, should that be somewhere noticed in the copyright statement?

They are not imported from OpenBSD but made independently. I have no evidences of it.

Only some parts of linux/rbtree.h was imported directly.

sys/compat/linuxkpi/common/include/linux/interval_tree_generic.h
5

They are not imported directly from OpenBSD. OpenBSD version of linux/interval_tree_generic.h is dummy file [1].
But our generic version is inspired by their particular interval_tree implementation, so I agree, I have to add kettenis@ to authors.

[1] https://github.com/openbsd/src/blob/master/sys/dev/pci/drm/include/linux/interval_tree_generic.h

This revision was automatically updated to reflect the committed changes.