lagg: update capabilites on SIOCSIFMTU
ClosedPublic
Actions

Authored by wma on Oct 29 2021, 9:03 AM.

Details

Reviewers

mw
jhb
loos
kd
hum_semihalf.com

Commits

rGacdfc0963946: lagg: update capabilites on SIOCSIFMTU

Summary

Update LAGG and VLAN capabilites on MTU change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wma created this revision.Oct 29 2021, 9:03 AM

Herald added subscribers: melifaro, ae. · View Herald TranscriptOct 29 2021, 9:03 AM

wma requested review of this revision.Oct 29 2021, 9:03 AM

Some NICs might have limited capabilities when Jumbo frames are used.
For exampe some neta interfaces only support TX csum offload when the
packet size is lower than a value specified in DT.
Fix it by re-reading capabilities of children interfaces after MTU
has been successfully changed.

Found by: Jerome Tomczyk <jerome.tomczyk@stormshield.eu>

I would perhaps leave out the comments (they aren't present in the lines above for SIOCSIFCAP) and adding the blank lines before them to conform to style(9) would make this a bit long.

This revision is now accepted and ready to land.Nov 4 2021, 8:59 PM

Closed by commit rGacdfc0963946: lagg: update capabilites on SIOCSIFMTU (authored by wma). · Explain WhyNov 6 2021, 9:43 AM

This revision was automatically updated to reflect the committed changes.

wma added a commit: rGacdfc0963946: lagg: update capabilites on SIOCSIFMTU.

Herald added a subscriber: imp. · View Herald TranscriptNov 6 2021, 9:43 AM