ifconfig: warn if setting an Internet address without mask
ClosedPublic
Actions

Authored by • karels on Oct 28 2021, 2:37 PM.

Details

Reviewers

Commits

rGd8237b955528: ifconfig: warn if setting an Internet address without mask

Summary

Add a postproc function for af_inet, and add interface flags as a
parameter. Check there if setting an address without a mask unless
the interface is loopback or point-to-point, where mask is not really
meaningful; warn if so. This will hopefully be an error in the future.

Test Plan

Tested with and without masks.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karels created this revision.Oct 28 2021, 2:37 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 28 2021, 2:37 PM

• karels requested review of this revision.Oct 28 2021, 2:37 PM

Harbormaster completed remote builds in B42414: Diff 97613.Oct 28 2021, 2:37 PM

Otherwise looks good to me but I am not the best ifconfig-review person; especially I cannot test the v4 changes (easily)

sbin/ifconfig/ifconfig.c
1182	Can you make this a bool?

Change getifflags() err_ok parameter to bool

Harbormaster completed remote builds in B42524: Diff 97871.Nov 2 2021, 4:03 PM

No one seems to have done structural work on ifconfig for a while. Suggestions for other reviewers welcome, but I think it is pretty well tested.

sbin/ifconfig/ifconfig.c
1182	Good suggestion, thanks.

Fix delete case

Harbormaster completed remote builds in B42586: Diff 98030.Nov 4 2021, 7:05 PM

Still looks okay (untested); the ifconfig man page examples section seemed to already look good; src/libexec/rc/rc.conf probably needs a pass as well.

bz accepted this revision.Nov 9 2021, 3:16 PM

This revision is now accepted and ready to land.Nov 9 2021, 3:16 PM

Closed by commit rGd8237b955528: ifconfig: warn if setting an Internet address without mask (authored by • karels). · Explain WhyNov 9 2021, 3:36 PM

This revision was automatically updated to reflect the committed changes.

• karels added a commit: rGd8237b955528: ifconfig: warn if setting an Internet address without mask.