Differential D32664

mbuf: PACKET_TAG_PF should not be persistent
ClosedPublic
Actions

Authored by kp on Oct 26 2021, 9:53 AM.

Tags

None

Referenced Files

	F81569800: D32664.diff
	Thu, Apr 18, 6:16 AM

	Unknown Object (File)
	Tue, Apr 16, 6:59 AM

	Unknown Object (File)
	Tue, Apr 16, 3:59 AM

	Unknown Object (File)
	Thu, Apr 11, 1:09 PM

	Unknown Object (File)
	Thu, Apr 4, 3:16 PM

	Unknown Object (File)
	Sun, Mar 31, 12:31 PM

	Unknown Object (File)
	Feb 11 2024, 5:34 AM

	Unknown Object (File)
	Feb 5 2024, 12:01 AM

View All 37 Files

Subscribers

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG2036a3a8a168: mbuf: PACKET_TAG_PF should not be persistent
rG4f524ecb040b: mbuf: PACKET_TAG_PF should not be persistent
rG7fe0c3f8d330: mbuf: PACKET_TAG_PF should not be persistent

Summary

We should clear firewall tags on loopback, icmp reflection, or if_epair
transmission. Left over tags can produce unexpected behaviour,
especially on if_epair where a and b interfaces can be in different
vnets, and have different firewall policies set.

MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Oct 26 2021, 9:53 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 26 2021, 9:53 AM

kp requested review of this revision.Oct 26 2021, 9:53 AM

Harbormaster completed remote builds in B42373: Diff 97466.Oct 26 2021, 9:53 AM

kp added a parent revision: D32663: if_epair: delete mbuf tags.Oct 26 2021, 9:53 AM

kp added a child revision: D32665: pf: fix dummynet + NAT.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 28 2021, 8:51 AM

Closed by commit rG7fe0c3f8d330: mbuf: PACKET_TAG_PF should not be persistent (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG7fe0c3f8d330: mbuf: PACKET_TAG_PF should not be persistent.

kp added a commit: rG4f524ecb040b: mbuf: PACKET_TAG_PF should not be persistent.Nov 19 2021, 6:40 AM

kp added a commit: rG2036a3a8a168: mbuf: PACKET_TAG_PF should not be persistent.

Revision Contents
Changeset List

Path

Size

sys/

sys/

2 lines

Diff 97599

sys/sys/mbuf.h

Loading...