Page MenuHomeFreeBSD

Fix some NewReno handlers in case of being called from other CC modules
ClosedPublic

Authored by tuexen on Oct 25 2021, 8:30 PM.

Details

Summary

Some NewReno functions use the internal data, but are also called from other CC modules. Ensure that in this case, the internal data is not accessed.

This should fix:

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tuexen retitled this revision from Fix some NewReno handlers in case of called from other CC modules to Fix some NewReno handlers in case of being called from other CC modules.
This revision is now accepted and ready to land.Oct 25 2021, 8:37 PM

Overall I think this is a good fix for an ugly problem. I.e. that other
CC algo's use newreno. I think we should re-look at this and have the
"reused" functions put into the kernel as just non-static functions that
can be used by CC modules. Pass in beta etc...

sys/netinet/cc/cc_newreno.c
404

nit double ;; on end