Page MenuHomeFreeBSD
Differential D32338

Allocate arm64 per-CPU data in the correct domain
ClosedPublic
Actions

Authored by andrew on Oct 6 2021, 3:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 11, 6:39 AM
Unknown Object (File)
Fri, Dec 5, 2:43 AM
Unknown Object (File)
Sun, Nov 23, 9:24 AM
Unknown Object (File)
Fri, Nov 21, 6:53 AM
Unknown Object (File)
Mon, Nov 17, 5:31 PM
Unknown Object (File)
Sat, Nov 15, 8:56 PM
Unknown Object (File)
Fri, Nov 14, 11:49 PM
Unknown Object (File)
Fri, Nov 14, 2:53 AM
View All Files
Subscribers
dch
emaste
imp

Details

Reviewers
kib
markj
manu
Group Reviewers
arm64
Commits
rGf51997c6e410: Allocate arm64 per-CPU data in the correct domain
rGa90ebeb5feea: Allocate arm64 per-CPU data in the correct domain
Summary

To minimise NUMA traffic allocate the pcpu, dpcpu, and boot stacks in
the correct domain when possible.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42001
Build 38889: arc lint + arc unit

Event Timeline

andrew created this revision.Oct 6 2021, 3:54 PM
Herald added a reviewer: manu. · View Herald TranscriptOct 6 2021, 3:54 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Oct 6 2021, 3:54 PM
Harbormaster completed remote builds in B41984: Diff 96347.Oct 6 2021, 3:54 PM
markj added inline comments.Oct 6 2021, 4:15 PM
sys/arm64/arm64/machdep.c
109

Isn't this the same as cpuid_to_pcpu[] now? Do we need __pcpu[] at all?

sys/arm64/arm64/mp_machdep.c
509
643

I think this probably deserves an XXX comment.

markj added inline comments.Oct 6 2021, 4:17 PM
sys/arm64/arm64/mp_machdep.c
518

FWIW, there is no benefit to allocating domain-local boot stacks, they are used only in the window after the AP starts and before it switches to a thread.

andrew updated this revision to Diff 96406.Oct 7 2021, 11:24 AM

Use cpuid_to_pcpu

Harbormaster completed remote builds in B42001: Diff 96406.Oct 7 2021, 11:24 AM
andrew added inline comments.Oct 7 2021, 11:25 AM
sys/arm64/arm64/mp_machdep.c
518

I mostly did it for consistency.

markj accepted this revision.Oct 7 2021, 4:02 PM
markj added inline comments.
sys/arm64/arm64/machdep.c
1363

We assume that .bss is allocated from the domain to which the BSP belongs. That's probably true in practice though, at least amd64 makes a similar assumption when it allocates the pcpu area in pmap_bootstrap().

This revision is now accepted and ready to land.Oct 7 2021, 4:02 PM
Closed by commit rGa90ebeb5feea: Allocate arm64 per-CPU data in the correct domain (authored by andrew). · Explain WhyOct 11 2021, 10:44 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGa90ebeb5feea: Allocate arm64 per-CPU data in the correct domain.
andrew added a commit: rGf51997c6e410: Allocate arm64 per-CPU data in the correct domain.Dec 14 2021, 11:07 AM
andrew added a reverting change: rGd33bf8c50bd7: Stop using the kmem for PCPU memory on arm64.Apr 27 2022, 2:25 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
9 lines
39 lines
include/
2 lines
2 lines

Diff 96406

View Options

sys/arm64/arm64/machdep.c

Loading...
View Options

sys/arm64/arm64/mp_machdep.c

Loading...
View Options

sys/arm64/include/counter.h

Loading...
View Options

sys/arm64/include/pcpu_aux.h

Loading...