Page MenuHomeFreeBSD

devmatch: Allow devmatch_blocklist to be set in kenv too
ClosedPublic

Authored by imp on Sep 28 2021, 3:07 AM.

Details

Summary

Add in all the variables set in the kenv variable devmatch_blocklist
too.

Sponsored by: Netflix

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp requested review of this revision.Sep 28 2021, 3:07 AM
imp created this revision.

Thanks! =D I think quoting is just one-off

libexec/rc/rc.d/devmatch
67

I think...

0mp added inline comments.
libexec/rc/rc.d/devmatch
67

Why don't we use " here?

libexec/rc/rc.d/devmatch
67

Too many years of paranoia... That would work.

sbin/devmatch/devmatch.8
78

Should we put this information into rc.conf(5) instead? Then we may leave a note here that the details are described in rc.conf(5).

Otherwise we seem to segment the documentation.

sbin/devmatch/devmatch.8
78

Yea, it's already there, so I'll expand it and remove this redundant copy. I'll add an Xr to rc.conf.5 from here though

Move to rc.conf.5 and add xref

Just one minor nit. Otherwise looks nice.

Please remember to bump Dd when comitting.

share/man/man5/rc.conf.5
266

"easiler" looks like a typo.

Suggestion: I think I'd just drop "easier" from here entirely. I'm not sure what the exact use case is for this variable, but maybe we could mention that it's meant to be used in loader and loader.conf (just to give the reader an inspiration of the possibilities).

This revision is now accepted and ready to land.Nov 19 2021, 9:09 AM