Add in all the variables set in the kenv variable devmatch_blocklist
too.
Sponsored by: Netflix
Details
Details
- Reviewers
kevans 0mp - Group Reviewers
manpages - Commits
- rGa8935083b518: devmatch: Allow devmatch_blocklist to be set in kenv too
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| libexec/rc/rc.d/devmatch | ||
|---|---|---|
| 67 | Why don't we use " here? | |
| libexec/rc/rc.d/devmatch | ||
|---|---|---|
| 67 | Too many years of paranoia... That would work. | |
| sbin/devmatch/devmatch.8 | ||
|---|---|---|
| 79 | Should we put this information into rc.conf(5) instead? Then we may leave a note here that the details are described in rc.conf(5). Otherwise we seem to segment the documentation. | |
| sbin/devmatch/devmatch.8 | ||
|---|---|---|
| 79 | Yea, it's already there, so I'll expand it and remove this redundant copy. I'll add an Xr to rc.conf.5 from here though | |
Comment Actions
Just one minor nit. Otherwise looks nice.
Please remember to bump Dd when comitting.
| share/man/man5/rc.conf.5 | ||
|---|---|---|
| 267 | "easiler" looks like a typo. Suggestion: I think I'd just drop "easier" from here entirely. I'm not sure what the exact use case is for this variable, but maybe we could mention that it's meant to be used in loader and loader.conf (just to give the reader an inspiration of the possibilities). | |