Page MenuHomeFreeBSD
Differential D31171

Assert that valid PTEs are not overwritten when installing a new PTP
ClosedPublic
Actions

Authored by markj on Jul 13 2021, 11:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2025, 10:25 AM
Unknown Object (File)
Feb 2 2025, 7:36 PM
Unknown Object (File)
Jan 25 2025, 8:01 PM
Unknown Object (File)
Jan 25 2025, 8:01 PM
Unknown Object (File)
Jan 24 2025, 3:14 AM
Unknown Object (File)
Jan 19 2025, 5:01 PM
Unknown Object (File)
Jan 13 2025, 9:45 PM
Unknown Object (File)
Jan 8 2025, 4:05 PM
View All 57 Files
Subscribers
andrew
emaste
imp
jhibbits

Details

Reviewers
manu
alc
kib
Commits
rGb092c58c006f: Assert that valid PTEs are not overwritten when installing a new PTP
Summary

amd64 and 32-bit ARM already had assertions to this effect. Add them to
other pmaps.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
6 lines
i386/
i386/
5 lines
mips/
mips/
4 lines
powerpc/
aim/
8 lines
riscv/
riscv/
4 lines

Diff 92234

View Options

sys/arm64/arm64/pmap.c

Show First 20 Lines • Show All 680 Lines • ▼ Show 20 Lineszfsctl_root_readdir(struct vop_readdir_args *ap)
/* /*
* FIXME: this routine only ever emits 3 entries and does not tolerate * FIXME: this routine only ever emits 3 entries and does not tolerate
* being called with a buffer too small to handle all of them. * being called with a buffer too small to handle all of them.
* *
* The check below facilitates the idiom of repeating calls until the * The check below facilitates the idiom of repeating calls until the
* count to return is 0. * count to return is 0.
*/ */
if (zfs_uio_offset(&uio) == 3 * sizeof(entry)) { if (zfs_uio_offset(&uio) == 3 * sizeof (entry)) {
jhbAuthorUnsubmitted
Done
Inline Actions

Possibly this should be fixed upstream instead, but having it as a local diff is needless.

jhb: Possibly this should be fixed upstream instead, but having it as a local diff is needless.
emasteUnsubmitted
Not Done
Inline Actions

I see 57 files with sizeof( and 385 with sizeof ( upstream (some files might have both styles and be double-counted) so it looks like our local diff is contrary to upstream's preferred style.

emaste: I see 57 files with `sizeof(` and 385 with `sizeof (` upstream (some files might have both…
return (0); return (0);
} }
error = sfs_readdir_common(zfsvfs->z_root, ZFSCTL_INO_ROOT, ap, &uio, error = sfs_readdir_common(zfsvfs->z_root, ZFSCTL_INO_ROOT, ap, &uio,
&dots_offset); &dots_offset);
if (error != 0) { if (error != 0) {
if (error == ENAMETOOLONG) /* ran out of destination space */ if (error == ENAMETOOLONG) /* ran out of destination space */
error = 0; error = 0;
▲ Show 20 Lines • Show All 682 Lines • Show Last 20 Lines
View Options

sys/i386/i386/pmap.c

Show First 20 Lines • Show All 680 Lines • ▼ Show 20 Lineszfsctl_root_readdir(struct vop_readdir_args *ap)
/* /*
* FIXME: this routine only ever emits 3 entries and does not tolerate * FIXME: this routine only ever emits 3 entries and does not tolerate
* being called with a buffer too small to handle all of them. * being called with a buffer too small to handle all of them.
* *
* The check below facilitates the idiom of repeating calls until the * The check below facilitates the idiom of repeating calls until the
* count to return is 0. * count to return is 0.
*/ */
if (zfs_uio_offset(&uio) == 3 * sizeof(entry)) { if (zfs_uio_offset(&uio) == 3 * sizeof (entry)) {
jhbAuthorUnsubmitted
Done
Inline Actions

Possibly this should be fixed upstream instead, but having it as a local diff is needless.

jhb: Possibly this should be fixed upstream instead, but having it as a local diff is needless.
emasteUnsubmitted
Not Done
Inline Actions

I see 57 files with sizeof( and 385 with sizeof ( upstream (some files might have both styles and be double-counted) so it looks like our local diff is contrary to upstream's preferred style.

emaste: I see 57 files with `sizeof(` and 385 with `sizeof (` upstream (some files might have both…
return (0); return (0);
} }
error = sfs_readdir_common(zfsvfs->z_root, ZFSCTL_INO_ROOT, ap, &uio, error = sfs_readdir_common(zfsvfs->z_root, ZFSCTL_INO_ROOT, ap, &uio,
&dots_offset); &dots_offset);
if (error != 0) { if (error != 0) {
if (error == ENAMETOOLONG) /* ran out of destination space */ if (error == ENAMETOOLONG) /* ran out of destination space */
error = 0; error = 0;
▲ Show 20 Lines • Show All 682 Lines • Show Last 20 Lines
View Options

sys/mips/mips/pmap.c

Show First 20 Lines • Show All 680 Lines • ▼ Show 20 Lineszfsctl_root_readdir(struct vop_readdir_args *ap)
/* /*
* FIXME: this routine only ever emits 3 entries and does not tolerate * FIXME: this routine only ever emits 3 entries and does not tolerate
* being called with a buffer too small to handle all of them. * being called with a buffer too small to handle all of them.
* *
* The check below facilitates the idiom of repeating calls until the * The check below facilitates the idiom of repeating calls until the
* count to return is 0. * count to return is 0.
*/ */
if (zfs_uio_offset(&uio) == 3 * sizeof(entry)) { if (zfs_uio_offset(&uio) == 3 * sizeof (entry)) {
jhbAuthorUnsubmitted
Done
Inline Actions

Possibly this should be fixed upstream instead, but having it as a local diff is needless.

jhb: Possibly this should be fixed upstream instead, but having it as a local diff is needless.
emasteUnsubmitted
Not Done
Inline Actions

I see 57 files with sizeof( and 385 with sizeof ( upstream (some files might have both styles and be double-counted) so it looks like our local diff is contrary to upstream's preferred style.

emaste: I see 57 files with `sizeof(` and 385 with `sizeof (` upstream (some files might have both…
return (0); return (0);
} }
error = sfs_readdir_common(zfsvfs->z_root, ZFSCTL_INO_ROOT, ap, &uio, error = sfs_readdir_common(zfsvfs->z_root, ZFSCTL_INO_ROOT, ap, &uio,
&dots_offset); &dots_offset);
if (error != 0) { if (error != 0) {
if (error == ENAMETOOLONG) /* ran out of destination space */ if (error == ENAMETOOLONG) /* ran out of destination space */
error = 0; error = 0;
▲ Show 20 Lines • Show All 682 Lines • Show Last 20 Lines
View Options

sys/powerpc/aim/mmu_radix.c

Show First 20 Lines • Show All 680 Lines • ▼ Show 20 Lineszfsctl_root_readdir(struct vop_readdir_args *ap)
/* /*
* FIXME: this routine only ever emits 3 entries and does not tolerate * FIXME: this routine only ever emits 3 entries and does not tolerate
* being called with a buffer too small to handle all of them. * being called with a buffer too small to handle all of them.
* *
* The check below facilitates the idiom of repeating calls until the * The check below facilitates the idiom of repeating calls until the
* count to return is 0. * count to return is 0.
*/ */
if (zfs_uio_offset(&uio) == 3 * sizeof(entry)) { if (zfs_uio_offset(&uio) == 3 * sizeof (entry)) {
jhbAuthorUnsubmitted
Done
Inline Actions

Possibly this should be fixed upstream instead, but having it as a local diff is needless.

jhb: Possibly this should be fixed upstream instead, but having it as a local diff is needless.
emasteUnsubmitted
Not Done
Inline Actions

I see 57 files with sizeof( and 385 with sizeof ( upstream (some files might have both styles and be double-counted) so it looks like our local diff is contrary to upstream's preferred style.

emaste: I see 57 files with `sizeof(` and 385 with `sizeof (` upstream (some files might have both…
return (0); return (0);
} }
error = sfs_readdir_common(zfsvfs->z_root, ZFSCTL_INO_ROOT, ap, &uio, error = sfs_readdir_common(zfsvfs->z_root, ZFSCTL_INO_ROOT, ap, &uio,
&dots_offset); &dots_offset);
if (error != 0) { if (error != 0) {
if (error == ENAMETOOLONG) /* ran out of destination space */ if (error == ENAMETOOLONG) /* ran out of destination space */
error = 0; error = 0;
▲ Show 20 Lines • Show All 682 Lines • Show Last 20 Lines
View Options

sys/riscv/riscv/pmap.c

Loading...