Page MenuHomeFreeBSD
Differential D30993

Check PMTU before sending a frame.
ClosedPublic
Actions

Authored by wma on Jul 2 2021, 4:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 29, 5:05 PM
Unknown Object (File)
Feb 29 2024, 4:22 PM
Unknown Object (File)
Feb 8 2024, 4:11 AM
Unknown Object (File)
Dec 26 2023, 4:05 PM
Unknown Object (File)
Dec 21 2023, 2:19 PM
Unknown Object (File)
Dec 20 2023, 3:20 AM
Unknown Object (File)
Nov 8 2023, 10:39 AM
Unknown Object (File)
Oct 7 2023, 9:34 AM
View All 24 Files
Subscribers
ae
melifaro

Details

Reviewers
mw
imp
np
tuexen
Commits
rG6b66194bcb7e: ipsec: Check PMTU before sending a frame.
Summary

If an encapsulated frame is going to have DF bit set check its desitnitions'
PMTU and if it won't fit drop it and:

  1. Generate ICMP 3/4 message if the packet was to be forwarded.
  2. Return EMSGSIZE error otherwise.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

wma created this revision.Jul 2 2021, 4:40 AM
Herald added subscribers: melifaro, ae. · View Herald TranscriptJul 2 2021, 4:40 AM
wma requested review of this revision.Jul 2 2021, 4:40 AM
melifaro added inline comments.Jul 4 2021, 11:28 AM
sys/netipsec/ipsec_output.c
357

why do we conditionally free m here?

ae added inline comments.Jul 5 2021, 8:59 AM
sys/netipsec/ipsec_output.c
357

icmp_error() always consumes mbuf.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 13 2021, 7:24 AM
Closed by commit rG6b66194bcb7e: ipsec: Check PMTU before sending a frame. (authored by kd, committed by wma). · Explain Why
This revision was automatically updated to reflect the committed changes.
wma added a commit: rG6b66194bcb7e: ipsec: Check PMTU before sending a frame..

Revision Contents
Changeset List

PathSize
sys/
netipsec/
2 lines
2 lines
87 lines

Diff 91643

View Options

sys/netipsec/ipsec.h

Loading...
View Options

sys/netipsec/ipsec.c

Loading...
View Options

sys/netipsec/ipsec_output.c

Loading...