Page MenuHomeFreeBSD
Differential D30993

Check PMTU before sending a frame.
ClosedPublic
Actions

Authored by wma on Jul 2 2021, 4:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 27, 7:28 PM
Unknown Object (File)
Mon, Feb 24, 5:09 AM
Unknown Object (File)
Fri, Feb 14, 5:15 PM
Unknown Object (File)
Jan 31 2025, 7:51 AM
Unknown Object (File)
Jan 30 2025, 7:09 AM
Unknown Object (File)
Jan 15 2025, 9:10 AM
Unknown Object (File)
Jan 15 2025, 5:08 AM
Unknown Object (File)
Dec 26 2024, 12:26 AM
View All 60 Files
Subscribers
ae
melifaro

Details

Reviewers
mw
imp
np
tuexen
Commits
rG6b66194bcb7e: ipsec: Check PMTU before sending a frame.
Summary

If an encapsulated frame is going to have DF bit set check its desitnitions'
PMTU and if it won't fit drop it and:

  1. Generate ICMP 3/4 message if the packet was to be forwarded.
  2. Return EMSGSIZE error otherwise.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

wma created this revision.Jul 2 2021, 4:40 AM
Herald added subscribers: melifaro, ae. · View Herald TranscriptJul 2 2021, 4:40 AM
wma requested review of this revision.Jul 2 2021, 4:40 AM
melifaro added inline comments.Jul 4 2021, 11:28 AM
sys/netipsec/ipsec_output.c
357

why do we conditionally free m here?

ae added inline comments.Jul 5 2021, 8:59 AM
sys/netipsec/ipsec_output.c
357

icmp_error() always consumes mbuf.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 13 2021, 7:24 AM
Closed by commit rG6b66194bcb7e: ipsec: Check PMTU before sending a frame. (authored by kd, committed by wma). · Explain Why
This revision was automatically updated to reflect the committed changes.
wma added a commit: rG6b66194bcb7e: ipsec: Check PMTU before sending a frame..

Revision Contents
Changeset List

PathSize
sys/
netipsec/
2 lines
2 lines
87 lines

Diff 91643

View Options

sys/netipsec/ipsec.h

Loading...
View Options

sys/netipsec/ipsec.c

Loading...
View Options

sys/netipsec/ipsec_output.c

Loading...