Page MenuHomeFreeBSD
Differential D30716

Rework Linux ppoll system call.
ClosedPublic
Actions

Authored by dchagin on Jun 10 2021, 12:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 6, 7:34 PM
Unknown Object (File)
Tue, Oct 6, 2:03 PM
Unknown Object (File)
Tue, Oct 6, 5:52 AM
Unknown Object (File)
Tue, Oct 6, 5:12 AM
Unknown Object (File)
Tue, Oct 6, 3:03 AM
Unknown Object (File)
Tue, Sep 29, 9:41 AM
Unknown Object (File)
Mon, Sep 21, 6:32 PM
Unknown Object (File)
Mon, Sep 21, 6:18 PM
View All Files
Subscribers
emaste
imp

Details

Reviewers
None
Group Reviewers
Linux Emulation
Commits
rGb2deba043c0c: linux(4): Rework Linux ppoll system call.
rG26795a0378b5: linux(4): Rework Linux ppoll system call.
Summary

For now the Linux emulation layer uses in kernel ppoll(2) without
conversion of user supplied fd 'events', and does not convert the
kernel supplied fd 'revents'.

At least POLLRDHUP is handled by FreeBSD differently than by
Linux. Seems that Linux silencly ignores POLLRDHUP on non socket fd's
unlike FreeBSD, which does more strictly check and fails.

Rework the Linux ppoll, using kern_poll and converting 'events'
and 'revents' values.
While here, move poll events defines to the MI part of code as they
mostly identical on all arches except arm.

Test Plan

ltp

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin created this revision.Jun 10 2021, 12:23 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 10 2021, 12:23 PM
dchagin requested review of this revision.Jun 10 2021, 12:23 PM
Harbormaster completed remote builds in B39831: Diff 90696.Jun 10 2021, 12:23 PM
dchagin added a reviewer: Linux Emulation.Jun 10 2021, 12:24 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
emaste added a subscriber: emaste.Jun 10 2021, 7:15 PM

Looks reasonable

sys/compat/linux/linux.c
686–689

we may need to add some sort of ratelimiting for these (as a followup)?

dchagin updated this revision to Diff 90722.Jun 11 2021, 10:02 AM

fix grammar, rate limit diagnostics.

Harbormaster completed remote builds in B39840: Diff 90722.Jun 11 2021, 10:02 AM
dchagin updated this revision to Diff 90773.Jun 11 2021, 9:47 PM

move conversion routines declaration to linux_common.h as
linux.h does not intended for MD things

Harbormaster completed remote builds in B39861: Diff 90773.Jun 11 2021, 9:47 PM
dchagin marked an inline comment as done.Jun 13 2021, 1:29 PM

emaste@, what are you think about using fget_unlocked() in linux_to_bsd_poll_events?

This revision was not accepted when it landed; it landed in state Needs Review.Jun 21 2021, 4:30 PM
Closed by commit rG26795a0378b5: linux(4): Rework Linux ppoll system call. (authored by dchagin). · Explain Why
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG26795a0378b5: linux(4): Rework Linux ppoll system call..
dchagin added a commit: rGb2deba043c0c: linux(4): Rework Linux ppoll system call..Jun 17 2022, 7:32 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux/
21 lines
linux32/
21 lines
compat/
linux/
17 lines
96 lines
4 lines
68 lines
i386/
linux/
21 lines

Diff 91170

View Options

sys/amd64/linux/linux.h

Loading...
View Options

sys/amd64/linux32/linux.h

Loading...
View Options

sys/compat/linux/linux.h

Loading...
View Options

sys/compat/linux/linux.c

Loading...
View Options

sys/compat/linux/linux_common.h

Loading...
View Options

sys/compat/linux/linux_misc.c

Loading...
View Options

sys/i386/linux/linux.h

Loading...