LinuxKPI: pci: cleanup some code and add support for "pcim" (managed)
ClosedPublic
Actions

Authored by bz on May 30 2021, 9:41 PM.

Details

Reviewers

Group Reviewers

Commits

rG3a606aadf2e7: LinuxKPI: pci: cleanup some code and add support for "pcim" (managed)
rGd4a4960c6559: LinuxKPI: pci: cleanup some code and add support for "pcim" (managed)

Summary

Restructure some code and add support for various "managed" versions
for PCI resource management.
This is beyond of what iwlwifi needs but some was found with other
wireless drivers and it mostly all goes together well.
Add one FreeBSD sepcific feature returning the resource rather than
the handle to allow us to use bus_*() functions in drivers directly.

Sponsored by: The FreeBSD Foundation
MFC after: 10 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.May 30 2021, 9:41 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMay 30 2021, 9:41 PM

bz requested review of this revision.May 30 2021, 9:41 PM

Harbormaster completed remote builds in B39575: Diff 90141.May 30 2021, 9:41 PM

bz mentioned this in D30686: linuxkpi: Add rom and romlen to struct pci_dev.Jun 7 2021, 9:58 PM

Anyone interested in this or should I go ahead and commit it?

I'd like two days more to look at this.

In D30558#690464, @hselasky wrote:

I'd like two days more to look at this.

ACK; That's fine; there's more out and Monday will be okay.

In D30558#690479, @bz wrote:

In D30558#690464, @hselasky wrote:

I'd like two days more to look at this.

ACK; That's fine; there's more out and Monday will be okay.

Do you think you'll have a chance in the next 48 hours to look at this or the other remaining reviews?

Two more comments and we are good to go.

sys/compat/linuxkpi/common/src/linux_pci.c
365	Factor this line into the lkpifill_pci_dev() function ?
445	Disable busmaster too?

Fold dev.release into lkpifill_pci_dev().

Harbormaster completed remote builds in B39970: Diff 91049.Jun 18 2021, 10:37 AM

bz added inline comments.Jun 18 2021, 10:37 AM

sys/compat/linuxkpi/common/src/linux_pci.c
365	Done. I just need to find the other change adding the 2nd case of this assignment and sort it there as well then.
445	pcim_enable_device() doesn't track that; and not under "enable_io". This is merely the private opposite of pci_enable_device().