Page MenuHomeFreeBSD

Refactor core dumping code a bit
ClosedPublic

Authored by trasz on May 20 2021, 8:56 PM.

Details

Summary

This makes it possible to use core_write(), core_output(),
and sbuf_drain_core_output(), in Linux coredump code. Moving
them out of imgact_elf.c is necessary because of the weird way
it's being built.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

trasz requested review of this revision.May 20 2021, 8:56 PM
kib added inline comments.
sys/kern/kern_exec.c
2014

As a follow-up, please somewhat clean this function:

  • rename 'p' to e.g. cp
  • add local var p for cp->td->td_proc and use it
This revision is now accepted and ready to land.May 20 2021, 9:38 PM
This revision was automatically updated to reflect the committed changes.