Paths

Table of Contentst

ipfw.8: Fix table example
ClosedPublic
Actions

Authored by donner on May 10 2021, 6:34 PM.

Details

Reviewers

ae
melifaro
gbe

Group Reviewers

manpages

Commits

rG0f6a5de5c7f0: ipfw.8: Fix table example
rG86f699f4a360: ipfw.8: Fix table example
rG72fe4684e01b: ipfw.8: Fix table example
rG802637be0645: ipfw.8: Fix table example

Summary

There are some erronous lines in the example, which are fixed now.

PR: 248943
Submitted by: Jose Luis Duran
MFC after: 2 weeks

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39102
Build 35991: arc lint + arc unit

Event Timeline

donner created this revision.May 10 2021, 6:34 PM

Herald added a reviewer: manpages. · View Herald TranscriptMay 10 2021, 6:34 PM

Herald added a subscriber: imp. · View Herald Transcript

donner requested review of this revision.May 10 2021, 6:34 PM

Harbormaster completed remote builds in B39102: Diff 88970.May 10 2021, 6:34 PM

melifaro accepted this revision.May 10 2021, 8:56 PM

This revision is now accepted and ready to land.May 10 2021, 8:56 PM

jlduran_gmail.com added a subscriber: jlduran_gmail.com.May 11 2021, 12:52 AM

jlduran_gmail.com added inline comments.May 11 2021, 1:07 AM

sbin/ipfw/ipfw.8
4458	I wonder if it should say `'table(T2)'`?

Table name fixed.

This revision now requires review to proceed.May 11 2021, 5:21 AM

Harbormaster completed remote builds in B39114: Diff 89006.May 11 2021, 5:21 AM

donner retitled this revision from ipfw.8: Fix NAT example to ipfw.8: Fix table example.May 11 2021, 5:22 AM

donner marked an inline comment as done.

donner added inline comments.

sbin/ipfw/ipfw.8
4458	You are right: T2. I missed this while copying the old patch.

gbe accepted this revision.May 11 2021, 2:55 PM

This revision is now accepted and ready to land.May 11 2021, 2:55 PM

Closed by commit rG802637be0645: ipfw.8: Fix table example (authored by donner). · Explain WhyMay 11 2021, 3:40 PM

This revision was automatically updated to reflect the committed changes.

donner marked an inline comment as done.

donner added a commit: rG802637be0645: ipfw.8: Fix table example.

donner added a commit: rG72fe4684e01b: ipfw.8: Fix table example.May 25 2021, 5:42 AM

donner added a commit: rG86f699f4a360: ipfw.8: Fix table example.May 25 2021, 5:47 AM

donner added a commit: rG0f6a5de5c7f0: ipfw.8: Fix table example.May 25 2021, 5:50 AM

Revision Contents
Changeset List

Path

Size

sbin/

ipfw/

ipfw.8

6 lines

Diff 88970

View Options

ipfw.8: Fix table exampleClosedPublicActions