Page MenuHomeFreeBSD
Differential D30073

e1000: Clean up igb_txrx
ClosedPublic
Actions

Authored by kbowling on May 1 2021, 11:34 PM.
Tags
None
Referenced Files
F156521288: D30073.diff
Thu, May 14, 9:21 AM
Unknown Object (File)
Fri, May 8, 8:04 PM
Unknown Object (File)
Fri, May 1, 10:35 PM
Unknown Object (File)
Wed, Apr 29, 3:23 AM
Unknown Object (File)
Wed, Apr 29, 3:15 AM
Unknown Object (File)
Tue, Apr 28, 11:30 PM
Unknown Object (File)
Tue, Apr 28, 11:28 PM
Unknown Object (File)
Tue, Apr 28, 11:26 PM
View All Files
Subscribers
None

Details

Reviewers
markj
marius
grehan
gallatin
erj
Group Reviewers
Intel Networking
Commits
rGa1b9408f97d1: e1000: Add missing branch prediction
rG0861c2c695a7: e1000: Clean up igb_txrx
rGb91bb9b07f75: e1000: Add missing branch prediction
rG4ccafcfc8693: e1000: Clean up igb_txrx
rG9fd0cda92d33: e1000: Add missing branch prediction
rG41f02257146d: e1000: Clean up igb_txrx
Summary

The intention here is to reduce differences with D30072. The main functional change is logical simplification in igb_rx_checksum.

Test Plan

Tested on I210 lagg with iperf3 etc

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kbowling requested review of this revision.May 1 2021, 11:34 PM
kbowling created this revision.
gallatin added inline comments.May 2 2021, 3:50 PM
sys/dev/e1000/igb_txrx.c
530

Maybe this is also worth a __predict_false()

534

I would not use a __predict here, as there is no v6 l3 checksum, so I assume that v6 packets would take the unpredicted path, and be penalized.

kbowling updated this revision to Diff 88931.May 10 2021, 4:06 AM

Thanks for catching those mistakes. Can you take a look, I'm happy with this at the moment.

markj accepted this revision.May 10 2021, 2:52 PM

Looks ok to me aside from the comments.

sys/dev/e1000/igb_txrx.c
495

This assignment isn't needed.

544

Indentation here should be by four spaces.

This revision is now accepted and ready to land.May 10 2021, 2:52 PM
gallatin accepted this revision.May 10 2021, 3:05 PM
kbowling mentioned this in D31227: igc: sync igc_txrx with igb.Jul 20 2021, 6:52 AM
Closed by commit rG41f02257146d: e1000: Clean up igb_txrx (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyJul 20 2021, 7:12 AM
This revision was automatically updated to reflect the committed changes.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG41f02257146d: e1000: Clean up igb_txrx.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG9fd0cda92d33: e1000: Add missing branch prediction.Jul 20 2021, 7:23 AM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG4ccafcfc8693: e1000: Clean up igb_txrx.Aug 3 2021, 2:05 AM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGb91bb9b07f75: e1000: Add missing branch prediction.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG0861c2c695a7: e1000: Clean up igb_txrx.Aug 3 2021, 2:12 AM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGa1b9408f97d1: e1000: Add missing branch prediction.

Revision Contents
Changeset List

PathSize
sys/
dev/
e1000/
119 lines

Diff 92466

View Options

sys/dev/e1000/igb_txrx.c

Loading...