Page MenuHomeFreeBSD

e1000: Clean up igb_txrx
ClosedPublic

Authored by kbowling on May 1 2021, 11:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 13, 9:14 AM
Unknown Object (File)
Thu, Sep 5, 11:39 PM
Unknown Object (File)
Thu, Sep 5, 4:34 PM
Unknown Object (File)
Wed, Sep 4, 4:34 PM
Unknown Object (File)
Wed, Sep 4, 3:49 PM
Unknown Object (File)
Wed, Sep 4, 11:34 AM
Unknown Object (File)
Wed, Sep 4, 11:26 AM
Unknown Object (File)
Wed, Aug 28, 3:24 PM
Subscribers
None

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kbowling created this revision.
sys/dev/e1000/igb_txrx.c
530

Maybe this is also worth a __predict_false()

534

I would not use a __predict here, as there is no v6 l3 checksum, so I assume that v6 packets would take the unpredicted path, and be penalized.

Thanks for catching those mistakes. Can you take a look, I'm happy with this at the moment.

Looks ok to me aside from the comments.

sys/dev/e1000/igb_txrx.c
495

This assignment isn't needed.

544

Indentation here should be by four spaces.

This revision is now accepted and ready to land.May 10 2021, 2:52 PM